scottk/OpenNetworkLinux
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenNetworkLinux.git synced 2025-12-25 09:17:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

[as5916-54xks] Enhance code per comment by Billie

Browse Source
This commit is contained in:
brandon_chuang
2019-01-18 15:37:50 +08:00
parent 4f211fcd86
commit 3198710006
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/platforms/accton/x86-64/x86-64-accton-as5916-54xks/modules/builds/x86-64-accton-as5916-54xks-sfp.c
View File

@@ -1425,11 +1425,16 @@ static ssize_t set_phy(struct device *dev, struct device_attribute *da,
int status;
char *token = NULL, *last = NULL, *delim = " ";
struct sfp_phy_write_data wdata;
char command[NUM_OF_PHY_REGISTERS * 3 + 3] = {0};
char *command = NULL;
char *ipmi_phy_tx_data = (char *)&wdata;
command = kzalloc(count+1, GFP_KERNEL);
if (!command) {
return -ENOMEM;
}
memset(&wdata, 0, sizeof(wdata));
memcpy(command, buf, sizeof(command));
memcpy(command, buf, count);
/* Parsing command into tokens */
token = __strtok_r(command, delim, &last);
@@ -1441,6 +1446,11 @@ static ssize_t set_phy(struct device *dev, struct device_attribute *da,
return status;
}
/* Validate each param length */
if (param > 0xFF) {
return -EINVAL;
}
ipmi_phy_tx_data[i++] = param;
token = __strtok_r(NULL, delim, &last);
}