scottk/UltraGrid
1
0
Fork 0
mirror of https://github.com/outbackdingo/UltraGrid.git synced 2026-03-21 21:40:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

get_local_address: use early return

Browse Source
This commit is contained in:
Martin Pulec
2024-06-05 08:45:06 +02:00
parent e290283659
commit bf36adeee8
1 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/utils/net.c
View File

@@ -74,6 +74,8 @@ typedef int fd_t;
#define IN_LOOPBACKNET 127
#endif
#define MOD_NAME "[utils/net] "
bool is_addr_linklocal(struct sockaddr *sa)
{
switch (sa->sa_family) {
@@ -315,26 +317,29 @@ bool get_local_addresses(struct sockaddr_storage *addrs, size_t *len, int ip_ver
getifaddrs(&a);
struct ifaddrs* p = a;
while (NULL != p) {
if (p->ifa_addr == NULL) {
if (p->ifa_addr == NULL ||
(ip_version == 0 && (p->ifa_addr->sa_family != AF_INET &&
p->ifa_addr->sa_family != AF_INET6)) ||
(ip_version == 4 && p->ifa_addr->sa_family != AF_INET) ||
(ip_version == 6 && p->ifa_addr->sa_family != AF_INET6)) {
p = p->ifa_next;
continue;
}
if ((ip_version == 0 && (p->ifa_addr->sa_family == AF_INET || p->ifa_addr->sa_family == AF_INET6)) ||
(ip_version == 4 && p->ifa_addr->sa_family == AF_INET) ||
(ip_version == 6 && p->ifa_addr->sa_family == AF_INET6)) {
if (available_len >= sizeof addrs[0]) {
size_t sa_len = p->ifa_addr->sa_family == AF_INET ? sizeof(struct sockaddr_in) : sizeof(struct sockaddr_in6);
memcpy(addrs, p->ifa_addr, sa_len);
addrs += 1;
*len += sizeof(addrs[0]);
available_len -= sizeof(addrs[0]);
} else {
printf("Warning: insufficient space for all addresses.\n");
return true;
}
}
p = p->ifa_next;
}
continue;
}
if (available_len < sizeof addrs[0]) {
MSG(WARNING,
"Warning: insufficient space for all addresses.\n");
return true;
}
size_t sa_len = p->ifa_addr->sa_family == AF_INET
? sizeof(struct sockaddr_in)
: sizeof(struct sockaddr_in6);
memcpy(addrs, p->ifa_addr, sa_len);
addrs += 1;
*len += sizeof(addrs[0]);
available_len -= sizeof(addrs[0]);
p = p->ifa_next;
}
if (NULL != a) {
freeifaddrs(a);
}