scottk/UltraGrid
1
0
Fork 0
mirror of https://github.com/outbackdingo/UltraGrid.git synced 2026-03-20 17:40:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

vcomp/lavc libsvtav1: do not set pred_struct=1

Browse Source 
currently it causes following error:
```
Svt[error]: VBR Rate control is currently not supported for SVT_AV1_PRED_LOW_DELAY_B, use CBR mode
```

Setting the CBR mode is currently not possible with current FFmpeg patch
- only possibility is to set rc_max_rate=bit_rate ([1] but this triggers
another error:
```
Svt[error]: Instance 1: Max Bitrate only supported with CRF mode
Svt[error]: CBR Rate control is currently not supported for SVT_AV1_PRED_RANDOM_ACCESS, use VBR mode
```

It is also not clear if the pred-struct set to SVT_AV1_PRED_LOW_DELAY_B
has some impact in situation when UG does not use B frames.

[1]: 5d54a25eea/libavcodec/libsvtav1.c (L224)
This commit is contained in:
Martin Pulec
2024-07-02 09:47:37 +02:00
parent 76e3db8029
commit fa8bb8ca8e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/video_compress/libavcodec.cpp
View File

@@ -1947,8 +1947,7 @@ static void configure_svt(AVCodecContext *codec_ctx, struct setparam_param *para
check_av_opt_set<const char *>(codec_ctx->priv_data, "preset",
preset);
#if LIBAVCODEC_VERSION_INT > AV_VERSION_INT(59, 21, 100)
//pred-struct=1 is low-latency mode
if (int ret = av_opt_set(codec_ctx->priv_data, "svtav1-params", "pred-struct=1:tile-columns=2:tile-rows=2", 0)) {
if (int ret = av_opt_set(codec_ctx->priv_data, "svtav1-params", "tile-columns=2:tile-rows=2", 0)) {
print_libav_error(LOG_LEVEL_WARNING, MOD_NAME "Unable to set svtav1-params for SVT", ret);
}
#else