chore: Fix Eslint warnings (#3654)

* Fix all the eslint warnings

* Revert the schema

.eslintrc.js

@@ -28,9 +28,7 @@ module.exports = {
     }],
     'vue/html-self-closing': 'off',
     "vue/no-v-html": 'off',
-    'vue/singleline-html-element-content-newline': 'warn',
+    'vue/singleline-html-element-content-newline': 'off',
-    'vue/require-default-prop': 'warn',
-    'vue/require-prop-types': 'warn',
     'import/extensions': ['off']
 
   },

app/javascript/dashboard/components/Snackbar.vue

@@ -11,7 +11,7 @@
 <script>
 export default {
   props: {
-    message: String,
+    message: { type: String, default: '' },
     showButton: Boolean,
     duration: {
       type: [String, Number],

app/javascript/dashboard/components/ui/Switch.vue

@@ -18,12 +18,11 @@
 export default {
   props: {
     disabled: Boolean,
-    isFullwidth: Boolean,
+    type: { type: String, default: '' },
-    type: String,
+    size: { type: String, default: '' },
-    size: String,
     checked: Boolean,
-    name: String,
+    name: { type: String, default: '' },
-    id: String,
+    id: { type: String, default: '' },
   },
   data() {
     return {

app/javascript/dashboard/components/widgets/EmptyState.vue

@@ -12,9 +12,9 @@
 <script>
 export default {
   props: {
-    title: String,
+    title: { type: String, default: '' },
-    message: String,
+    message: { type: String, default: '' },
-    buttonText: String,
+    buttonText: { type: String, default: '' },
   },
 };
 </script>

app/javascript/dashboard/components/widgets/LoadingState.vue

@@ -1,12 +1,12 @@
 <template>
   <div class="row loading-state">
-    <h6 class="message">{{ message }}<span class="spinner"></span></h6>
+    <h6 class="message">{{ message }}<span class="spinner" /></h6>
   </div>
 </template>
 <script>
 export default {
   props: {
-    message: String,
+    message: { type: String, default: '' },
   },
 };
 </script>

app/javascript/dashboard/components/widgets/ReportStatsCard.vue

@@ -18,12 +18,12 @@
 <script>
 export default {
   props: {
-    heading: String,
+    heading: { type: String, default: '' },
-    point: [Number, String],
+    point: { type: [Number, String], default: '' },
-    index: Number,
+    index: { type: Number, default: null },
-    desc: String,
+    desc: { type: String, default: '' },
     selected: Boolean,
-    onClick: Function,
+    onClick: { type: Function, default: () => {} },
   },
 };
 </script>

app/javascript/dashboard/components/widgets/modal/DeleteModal.vue

@@ -21,12 +21,12 @@ export default {
   },
   props: {
     show: Boolean,
-    onClose: Function,
+    onClose: { type: Function, default: () => {} },
-    onConfirm: Function,
+    onConfirm: { type: Function, default: () => {} },
-    title: String,
+    title: { type: String, default: '' },
-    message: String,
+    message: { type: String, default: '' },
-    confirmText: String,
+    confirmText: { type: String, default: '' },
-    rejectText: String,
+    rejectText: { type: String, default: '' },
   },
 };
 </script>

app/javascript/dashboard/routes/auth/PasswordEdit.vue

@@ -57,9 +57,9 @@ export default {
     WootSubmitButton,
   },
   props: {
-    resetPasswordToken: String,
+    resetPasswordToken: { type: String, default: '' },
-    redirectUrl: String,
+    redirectUrl: { type: String, default: '' },
-    config: String,
+    config: { type: String, default: '' },
   },
   data() {
     return {

app/javascript/dashboard/routes/dashboard/settings/SettingsSubPageHeader.vue

@@ -10,8 +10,8 @@
 <script>
 export default {
   props: {
-    headerTitle: String,
+    headerTitle: { type: String, default: '' },
-    headerContent: String,
+    headerContent: { type: String, default: '' },
   },
 };
 </script>

app/javascript/dashboard/routes/dashboard/settings/Wrapper.vue

@@ -25,9 +25,9 @@ export default {
     SettingsHeader,
   },
   props: {
-    headerTitle: String,
+    headerTitle: { type: String, default: '' },
-    headerButtonText: String,
+    headerButtonText: { type: String, default: '' },
-    icon: String,
+    icon: { type: String, default: '' },
     keepAlive: {
       type: Boolean,
       default: true,

app/javascript/dashboard/routes/dashboard/settings/canned/EditCanned.vue

@@ -61,10 +61,10 @@ export default {
     Modal,
   },
   props: {
-    id: Number,
+    id: { type: Number, default: null },
-    edcontent: String,
+    edcontent: { type: String, default: '' },
-    edshortCode: String,
+    edshortCode: { type: String, default: '' },
-    onClose: Function,
+    onClose: { type: Function, default: () => {} },
   },
   data() {
     return {

app/javascript/dashboard/routes/dashboard/settings/integrationapps/IntegrationItem.vue

@@ -47,8 +47,8 @@ export default {
   mixins: [globalConfigMixin],
   props: {
     integrationId: {
-      type: String,
+      type: [String, Number],
-      default: '',
+      required: true,
     },
     integrationLogo: {
       type: String,

app/javascript/dashboard/routes/dashboard/settings/integrations/Integration.vue

@@ -68,14 +68,17 @@ import globalConfigMixin from 'shared/mixins/globalConfigMixin';
 
 export default {
   mixins: [alertMixin, globalConfigMixin],
-  props: [
+  props: {
-    'integrationId',
+    integrationId: {
-    'integrationLogo',
+      type: [String, Number],
-    'integrationName',
+      required: true,
-    'integrationDescription',
+    },
-    'integrationEnabled',
+    integrationLogo: { type: String, default: '' },
-    'integrationAction',
+    integrationName: { type: String, default: '' },
-  ],
+    integrationDescription: { type: String, default: '' },
+    integrationEnabled: { type: Boolean, default: false },
+    integrationAction: { type: String, default: '' },
+  },
   data() {
     return {
       showDeleteConfirmationPopup: false,

app/javascript/dashboard/routes/dashboard/settings/integrations/ShowIntegration.vue

@@ -33,7 +33,14 @@ export default {
     IntegrationHelpText,
   },
   mixins: [globalConfigMixin],
-  props: ['integrationId', 'code'],
+
+  props: {
+    integrationId: {
+      type: [String, Number],
+      required: true,
+    },
+    code: { type: String, default: '' },
+  },
   data() {
     return {
       integrationLoaded: false,

app/javascript/shared/components/GreetingsEditor.vue

@@ -56,7 +56,7 @@ export default {
     };
   },
   watch: {
-    value: function(newValue) {
+    value(newValue) {
       this.greetingsMessage = newValue;
     },
   },

app/javascript/widget/components/ImageBubble.vue

@@ -19,7 +19,11 @@
 
 <script>
 export default {
-  props: ['url', 'thumb', 'readableTime'],
+  props: {
+    url: { type: String, default: '' },
+    thumb: { type: String, default: '' },
+    readableTime: { type: String, default: '' },
+  },
   methods: {
     onImgError() {
       this.$emit('error');

app/javascript/widget/components/UserAvatar.vue

@@ -11,9 +11,11 @@ export default {
   props: {
     src: {
       type: String,
+      default: '',
     },
     size: {
       type: String,
+      default: '',
     },
   },
   computed: {