mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-03 12:37:56 +00:00
revert: "chore: Replace messageMixing with useMessage composable [CW-3475]" (#10011)
Reverts chatwoot/chatwoot#9942 This was causing the widget email input to break
This commit is contained in:
@@ -9,7 +9,7 @@ import FileBubble from 'widget/components/FileBubble.vue';
|
|||||||
import Thumbnail from 'dashboard/components/widgets/Thumbnail.vue';
|
import Thumbnail from 'dashboard/components/widgets/Thumbnail.vue';
|
||||||
import { MESSAGE_TYPE } from 'widget/helpers/constants';
|
import { MESSAGE_TYPE } from 'widget/helpers/constants';
|
||||||
import configMixin from '../mixins/configMixin';
|
import configMixin from '../mixins/configMixin';
|
||||||
import { useMessage } from '../composables/useMessage';
|
import messageMixin from '../mixins/messageMixin';
|
||||||
import { isASubmittedFormMessage } from 'shared/helpers/MessageTypeHelper';
|
import { isASubmittedFormMessage } from 'shared/helpers/MessageTypeHelper';
|
||||||
import darkModeMixin from 'widget/mixins/darkModeMixin.js';
|
import darkModeMixin from 'widget/mixins/darkModeMixin.js';
|
||||||
import ReplyToChip from 'widget/components/ReplyToChip.vue';
|
import ReplyToChip from 'widget/components/ReplyToChip.vue';
|
||||||
@@ -28,7 +28,7 @@ export default {
|
|||||||
MessageReplyButton,
|
MessageReplyButton,
|
||||||
ReplyToChip,
|
ReplyToChip,
|
||||||
},
|
},
|
||||||
mixins: [configMixin, darkModeMixin],
|
mixins: [configMixin, messageMixin, darkModeMixin],
|
||||||
props: {
|
props: {
|
||||||
message: {
|
message: {
|
||||||
type: Object,
|
type: Object,
|
||||||
@@ -39,15 +39,6 @@ export default {
|
|||||||
default: () => {},
|
default: () => {},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
setup(props) {
|
|
||||||
const { messageContentAttributes, hasAttachments } = useMessage(
|
|
||||||
props.message
|
|
||||||
);
|
|
||||||
return {
|
|
||||||
messageContentAttributes,
|
|
||||||
hasAttachments,
|
|
||||||
};
|
|
||||||
},
|
|
||||||
data() {
|
data() {
|
||||||
return {
|
return {
|
||||||
hasImageError: false,
|
hasImageError: false,
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ import VideoBubble from 'widget/components/VideoBubble.vue';
|
|||||||
import FluentIcon from 'shared/components/FluentIcon/Index.vue';
|
import FluentIcon from 'shared/components/FluentIcon/Index.vue';
|
||||||
import FileBubble from 'widget/components/FileBubble.vue';
|
import FileBubble from 'widget/components/FileBubble.vue';
|
||||||
import { messageStamp } from 'shared/helpers/timeHelper';
|
import { messageStamp } from 'shared/helpers/timeHelper';
|
||||||
import { useMessage } from '../composables/useMessage';
|
import messageMixin from '../mixins/messageMixin';
|
||||||
import ReplyToChip from 'widget/components/ReplyToChip.vue';
|
import ReplyToChip from 'widget/components/ReplyToChip.vue';
|
||||||
import DragWrapper from 'widget/components/DragWrapper.vue';
|
import DragWrapper from 'widget/components/DragWrapper.vue';
|
||||||
import { BUS_EVENTS } from 'shared/constants/busEvents';
|
import { BUS_EVENTS } from 'shared/constants/busEvents';
|
||||||
@@ -25,6 +25,7 @@ export default {
|
|||||||
ReplyToChip,
|
ReplyToChip,
|
||||||
DragWrapper,
|
DragWrapper,
|
||||||
},
|
},
|
||||||
|
mixins: [messageMixin],
|
||||||
props: {
|
props: {
|
||||||
message: {
|
message: {
|
||||||
type: Object,
|
type: Object,
|
||||||
@@ -35,12 +36,6 @@ export default {
|
|||||||
default: () => {},
|
default: () => {},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
setup(props) {
|
|
||||||
const { hasAttachments } = useMessage(props.message);
|
|
||||||
return {
|
|
||||||
hasAttachments,
|
|
||||||
};
|
|
||||||
},
|
|
||||||
data() {
|
data() {
|
||||||
return {
|
return {
|
||||||
hasImageError: false,
|
hasImageError: false,
|
||||||
|
|||||||
@@ -1,71 +0,0 @@
|
|||||||
import { describe, it, expect } from 'vitest';
|
|
||||||
import { reactive, nextTick } from 'vue';
|
|
||||||
import { useMessage } from '../useMessage';
|
|
||||||
|
|
||||||
describe('useMessage', () => {
|
|
||||||
it('should handle deleted messages', () => {
|
|
||||||
const message = reactive({
|
|
||||||
content_attributes: { deleted: true },
|
|
||||||
attachments: [],
|
|
||||||
});
|
|
||||||
|
|
||||||
const { messageContentAttributes, hasAttachments } = useMessage(message);
|
|
||||||
|
|
||||||
expect(messageContentAttributes.value).toEqual({ deleted: true });
|
|
||||||
expect(hasAttachments.value).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('should handle non-deleted messages with attachments', () => {
|
|
||||||
const message = reactive({
|
|
||||||
content_attributes: {},
|
|
||||||
attachments: ['attachment1', 'attachment2'],
|
|
||||||
});
|
|
||||||
|
|
||||||
const { messageContentAttributes, hasAttachments } = useMessage(message);
|
|
||||||
|
|
||||||
expect(messageContentAttributes.value).toEqual({});
|
|
||||||
expect(hasAttachments.value).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('should handle messages without content_attributes', () => {
|
|
||||||
const message = reactive({
|
|
||||||
attachments: [],
|
|
||||||
});
|
|
||||||
|
|
||||||
const { messageContentAttributes, hasAttachments } = useMessage(message);
|
|
||||||
|
|
||||||
expect(messageContentAttributes.value).toEqual({});
|
|
||||||
expect(hasAttachments.value).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('should handle messages with empty attachments array', () => {
|
|
||||||
const message = reactive({
|
|
||||||
content_attributes: { someAttribute: 'value' },
|
|
||||||
attachments: [],
|
|
||||||
});
|
|
||||||
|
|
||||||
const { messageContentAttributes, hasAttachments } = useMessage(message);
|
|
||||||
|
|
||||||
expect(messageContentAttributes.value).toEqual({ someAttribute: 'value' });
|
|
||||||
expect(hasAttachments.value).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('should update reactive properties when message changes', async () => {
|
|
||||||
const message = reactive({
|
|
||||||
content_attributes: {},
|
|
||||||
attachments: [],
|
|
||||||
});
|
|
||||||
|
|
||||||
const { messageContentAttributes, hasAttachments } = useMessage(message);
|
|
||||||
|
|
||||||
expect(messageContentAttributes.value).toEqual({});
|
|
||||||
expect(hasAttachments.value).toBe(false);
|
|
||||||
|
|
||||||
message.content_attributes = { updated: true };
|
|
||||||
message.attachments.push('newAttachment');
|
|
||||||
await nextTick();
|
|
||||||
|
|
||||||
expect(messageContentAttributes.value).toEqual({ updated: true });
|
|
||||||
expect(hasAttachments.value).toBe(true);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -1,22 +0,0 @@
|
|||||||
import { computed } from 'vue';
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Composable for handling message-related computations.
|
|
||||||
* @param {Object} message - The message object to be processed.
|
|
||||||
* @returns {Object} An object containing computed properties for message content and attachments.
|
|
||||||
*/
|
|
||||||
export function useMessage(message) {
|
|
||||||
const messageContentAttributes = computed(() => {
|
|
||||||
const { content_attributes: attribute = {} } = message;
|
|
||||||
return attribute;
|
|
||||||
});
|
|
||||||
|
|
||||||
const hasAttachments = computed(() => {
|
|
||||||
return !!(message.attachments && message.attachments.length > 0);
|
|
||||||
});
|
|
||||||
|
|
||||||
return {
|
|
||||||
messageContentAttributes,
|
|
||||||
hasAttachments,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
13
app/javascript/widget/mixins/messageMixin.js
Normal file
13
app/javascript/widget/mixins/messageMixin.js
Normal file
@@ -0,0 +1,13 @@
|
|||||||
|
export default {
|
||||||
|
computed: {
|
||||||
|
messageContentAttributes() {
|
||||||
|
const { content_attributes: attribute = {} } = this.message;
|
||||||
|
return attribute;
|
||||||
|
},
|
||||||
|
hasAttachments() {
|
||||||
|
return !!(
|
||||||
|
this.message.attachments && this.message.attachments.length > 0
|
||||||
|
);
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
37
app/javascript/widget/mixins/specs/messageMixin.spec.js
Normal file
37
app/javascript/widget/mixins/specs/messageMixin.spec.js
Normal file
@@ -0,0 +1,37 @@
|
|||||||
|
import { shallowMount } from '@vue/test-utils';
|
||||||
|
import messageMixin from '../messageMixin';
|
||||||
|
import messages from './messageFixture';
|
||||||
|
|
||||||
|
describe('messageMixin', () => {
|
||||||
|
let Component = {
|
||||||
|
render() {},
|
||||||
|
title: 'TestComponent',
|
||||||
|
mixins: [messageMixin],
|
||||||
|
};
|
||||||
|
|
||||||
|
it('deleted messages', async () => {
|
||||||
|
const wrapper = shallowMount(Component, {
|
||||||
|
data() {
|
||||||
|
return {
|
||||||
|
message: messages.deletedMessage,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(wrapper.vm.messageContentAttributes).toEqual({
|
||||||
|
deleted: true,
|
||||||
|
});
|
||||||
|
expect(wrapper.vm.hasAttachments).toBe(false);
|
||||||
|
});
|
||||||
|
it('non-deleted messages', async () => {
|
||||||
|
const wrapper = shallowMount(Component, {
|
||||||
|
data() {
|
||||||
|
return {
|
||||||
|
message: messages.nonDeletedMessage,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(wrapper.vm.deletedMessage).toBe(undefined);
|
||||||
|
expect(wrapper.vm.messageContentAttributes).toEqual({});
|
||||||
|
expect(wrapper.vm.hasAttachments).toBe(true);
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in New Issue
Block a user