mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-03 19:58:17 +00:00 
			
		
		
		
	use input parameter that is invalid before
This commit is contained in:
		@@ -40,7 +40,7 @@ type diskManager interface {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// utility to mount a disk based filesystem
 | 
			
		||||
func diskSetUp(manager diskManager, b fcDiskMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy, plugin volume.VolumePlugin) error {
 | 
			
		||||
func diskSetUp(manager diskManager, b fcDiskMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy) error {
 | 
			
		||||
	globalPDPath := manager.MakeGlobalPDName(*b.fcDisk)
 | 
			
		||||
	noMnt, err := mounter.IsLikelyNotMountPoint(volPath)
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -362,7 +362,7 @@ func (b *fcDiskMounter) SetUp(mounterArgs volume.MounterArgs) error {
 | 
			
		||||
 | 
			
		||||
func (b *fcDiskMounter) SetUpAt(dir string, mounterArgs volume.MounterArgs) error {
 | 
			
		||||
	// diskSetUp checks mountpoints and prevent repeated calls
 | 
			
		||||
	err := diskSetUp(b.manager, *b, dir, b.mounter, mounterArgs.FsGroup, mounterArgs.FSGroupChangePolicy, b.plugin)
 | 
			
		||||
	err := diskSetUp(b.manager, *b, dir, b.mounter, mounterArgs.FsGroup, mounterArgs.FSGroupChangePolicy)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		klog.Errorf("fc: failed to setup")
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
@@ -42,7 +42,7 @@ type diskManager interface {
 | 
			
		||||
// utility to mount a disk based filesystem
 | 
			
		||||
// globalPDPath: global mount path like, /var/lib/kubelet/plugins/kubernetes.io/iscsi/{ifaceName}/{portal-some_iqn-lun-lun_id}
 | 
			
		||||
// volPath: pod volume dir path like, /var/lib/kubelet/pods/{podUID}/volumes/kubernetes.io~iscsi/{volumeName}
 | 
			
		||||
func diskSetUp(manager diskManager, b iscsiDiskMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy, plugin volume.VolumePlugin) error {
 | 
			
		||||
func diskSetUp(manager diskManager, b iscsiDiskMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy) error {
 | 
			
		||||
	notMnt, err := mounter.IsLikelyNotMountPoint(volPath)
 | 
			
		||||
	if err != nil && !os.IsNotExist(err) {
 | 
			
		||||
		klog.Errorf("cannot validate mountpoint: %s", volPath)
 | 
			
		||||
 
 | 
			
		||||
@@ -345,7 +345,7 @@ func (b *iscsiDiskMounter) SetUp(mounterArgs volume.MounterArgs) error {
 | 
			
		||||
 | 
			
		||||
func (b *iscsiDiskMounter) SetUpAt(dir string, mounterArgs volume.MounterArgs) error {
 | 
			
		||||
	// diskSetUp checks mountpoints and prevent repeated calls
 | 
			
		||||
	err := diskSetUp(b.manager, *b, dir, b.mounter, mounterArgs.FsGroup, mounterArgs.FSGroupChangePolicy, b.plugin)
 | 
			
		||||
	err := diskSetUp(b.manager, *b, dir, b.mounter, mounterArgs.FsGroup, mounterArgs.FSGroupChangePolicy)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		klog.Errorf("iscsi: failed to setup")
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
@@ -58,7 +58,7 @@ type diskManager interface {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// utility to mount a disk based filesystem
 | 
			
		||||
func diskSetUp(manager diskManager, b rbdMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy, plugin volume.VolumePlugin) error {
 | 
			
		||||
func diskSetUp(manager diskManager, b rbdMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy) error {
 | 
			
		||||
	globalPDPath := manager.MakeGlobalPDName(*b.rbd)
 | 
			
		||||
	notMnt, err := mounter.IsLikelyNotMountPoint(globalPDPath)
 | 
			
		||||
	if err != nil && !os.IsNotExist(err) {
 | 
			
		||||
 
 | 
			
		||||
@@ -837,7 +837,7 @@ func (b *rbdMounter) SetUp(mounterArgs volume.MounterArgs) error {
 | 
			
		||||
func (b *rbdMounter) SetUpAt(dir string, mounterArgs volume.MounterArgs) error {
 | 
			
		||||
	// diskSetUp checks mountpoints and prevent repeated calls
 | 
			
		||||
	klog.V(4).Infof("rbd: attempting to setup at %s", dir)
 | 
			
		||||
	err := diskSetUp(b.manager, *b, dir, b.mounter, mounterArgs.FsGroup, mounterArgs.FSGroupChangePolicy, b.plugin)
 | 
			
		||||
	err := diskSetUp(b.manager, *b, dir, b.mounter, mounterArgs.FsGroup, mounterArgs.FSGroupChangePolicy)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		klog.Errorf("rbd: failed to setup at %s %v", dir, err)
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user