Commit Graph

1558 Commits

Author SHA1 Message Date
EstherLerouzic
09221504d7 Add yang trees
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I98a16ebea347ff4913840cf6f563c34ebcf8f8d9
2025-09-26 11:52:56 +02:00
EstherLerouzic
f2039fbe1c fix: use loaded json instead of Path for extra configs
In order to be used by API.

Co-authored-by: Renato Ambrosone <renato.ambrosone@polito.it>

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I12111427c8a90b85b3158cdd95f4ee771cb39316
2025-09-26 11:17:45 +02:00
EstherLerouzic
78227e65da fix documentation and release notes
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I18457b1bdebd92bdd547877760a039706ad995a3
2025-09-26 11:17:45 +02:00
EstherLerouzic
e27e6d5c7b chore: add release notes
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ia561105ac5b3fa246bbd26a37e495e0d2ae92041
2025-09-26 11:17:45 +02:00
EstherLerouzic
e3445e1066 Update maintainer names
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I9122bfcf91a6cb55a6c50f98c6944086a21b1b73
2025-09-26 11:17:45 +02:00
EstherLerouzic
a0758d0da5 Move and refactor create_eqpt_sheet.py and add tests on it
Co-authored-by: Rodrigo Sasse David <rodrigo.sassedavid@orange.com>

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ib961c5c0e203f2225a0f1e2e7a091485567189c3
2025-09-26 11:17:45 +02:00
EstherLerouzic
0bc1fb3bf8 fix: Use openpyxl for xlsx reading and move to latest xlrd version
Create a set of excel utils to be used for .xls and .xlsx files, for
reading workbook, reading sheets, ... optimize openpyxl access to
sheet to save computation time.

Use this opportunity to refactor service sheet without namedtuple
and simplify code

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ibaf3aac40b3f6ca4829d8ea8cd506523d318103a
2025-09-26 11:17:45 +02:00
Arturo Mayoral
cd9d4c55b2 Publish calendar at docs/calendar.html and update README link to GitHub Pages
Change-Id: I0381b8d8ebcf3b40d15d1e80fa22bbc3613348e3
2025-09-17 13:13:51 +02:00
EstherLerouzic
62889bf6af feat: add a console script for yang conversion
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: If5ec36beec9d90b2f3d8c08c7fb5b629ad722245
2025-09-03 12:58:21 +02:00
EstherLerouzic
61787d5052 feat: parametrize the function that computes power targets
enable changing the reference span loss and the ratio of the
loss deviation to this reference that should be reported on
the span input.

Initial target used a hardcoded 20dB loss span with
0.3 power slope.

update documentation accordingly.

requires yang updates
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ib763db6be2bd7e947057176f3246f19ac7e6ac0d
2025-09-03 10:34:16 +02:00
Florian FRANK
6612a46a9e Fix to_json()-function of Multiband_amplifier when gain is missing
Signed-off-by: Florian FRANK <florian1.frank@orange.com>
Change-Id: I2a0c249c7e3278e282c2c45ea8be52073f014de3
2025-09-03 10:34:16 +02:00
EstherLerouzic
f30515ba9d fix: do not replace 0 with None
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I02ee8f4f1148873fd19f1c312578bc1f15355667
2025-09-03 10:34:16 +02:00
EstherLerouzic
6f9897fe40 fix: do not crash if type_variety is not defined when saving network
before autodesign type_variety may not be created yet, while ther is one default in params:
use type_variety from params

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I556bc8fa1a8241054c81cee386cf52b94a76a0bc
2025-09-03 10:34:16 +02:00
EstherLerouzic
56e615c713 Feat: Use a reference channel per OMS instead of total power for design
Correctly uses the oms band and spacing for computing the nb of channel
and total power for design per band.
In order to keep the SI values as reference, introduce a new parameter
in SI to indicate wether to use this feature or not.

If "use_si_channel_count_for_design": true, then the f_min, f_max and spacing
from SI are used for all OMSes
else, the f_min, f_max, spacing defined per OMS (design_bands) is used.

This impacts tests where the artificial C-band boudaries were hardcoded, and
it also has an impact on performances when SI's defined nb of channels is larger
than the one defined per OMS. In this case the design was considering a larger
total power than the one finally propagated which resulted in reduced performance.
This feature now corrects this case (if "use_si_channel_count_for_design": false
which is the default setting). Overall autodesign are thus improved.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I471a2c45200894ca354c90b46b662f42414b48ad

tous les test marche et les jeu de tests aussi.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: If25b47aa10f97301fde7f17daa2a9478aed46db2
2025-09-03 10:34:15 +02:00
EstherLerouzic
f447c908bc Feat: Add spacing info in the design_band info
This will be used to compute the max total power for design per OMS.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I392f06c792af9f32d4a14324c683bd3fae655de8
2025-09-03 10:34:15 +02:00
EstherLerouzic
4df6cc6b23 fix bug: use preselected restrictions also for raman flag true
otherwise restrictions that include raman are not correctly selected
eg for preamp with raman restriction in ROADM

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ie0215ca430cf463a5422d9236745710ab92ade59
2025-09-03 10:34:15 +02:00
EstherLerouzic
6c5d11d86c Implement in_voa of amplifiers
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I24feed756586a104e829275244f0868a272e5f6b
2025-09-03 10:34:15 +02:00
EstherLerouzic
1a795639c7 feat: Add conversion utilities for YANG and legacy formats in GNPy
This commit introduces new functions for converting between YANG formatted files and
legacy formats. The conversion processes adhere to RFC7951 for encoding YANG data.

Key changes include:
- Conversion of float and empty type representations.
- Transformation of Span and SI lists xx_power_range into dictionaries.
- Addition of necessary namespaces.
- use of oopt-gnpy-libyang to enforce compliancy to yang models

These utilities enable full compatibility with GNPy.

Co-authored-by: Renato Ambrosone <renato.ambrosone@polito.it>

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ia004113bca2b0631d1648564e5ccb60504fe80f8
2025-09-03 10:34:14 +02:00
EstherLerouzic
ee5e6f9b9e fix(CI): remove windows 2019, add windows 2025 support
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I133f5603f00d03e33add8842d34d692ab8fb1804
2025-09-03 10:34:14 +02:00
EstherLerouzic
ea4ab1d61b fix: place index first in the request-list because of libyang bug
libyang does not find key in data if not placed first in the data

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I63b9aa619e15d770e2dcb59010223318d2518eb7
2025-06-30 09:21:42 +02:00
EstherLerouzic
d43fee5945 fix: save network_name
network_name was not correctly exported in json output.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ia4ae6bf82e5d147d3c99e195151942abc21be3f3
2025-06-30 09:21:42 +02:00
EstherLerouzic
6603a50e78 chore: gnpy yang models
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I68502e76e27b43d2a6f6a5741045df3095fc7ccd
2025-06-30 09:21:39 +02:00
EstherLerouzic
b76c529c0c chore: import external ietf modules
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I02ed156105736ab538e4d5708d38b497f9479658
2025-06-11 15:05:51 +02:00
EstherLerouzic
7a1b15a916 chore: make sure all python files have the correct header
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ifdd6a566fda74c5b7d417f9d61c51d4d3da07bfd
2025-06-11 15:05:51 +02:00
EstherLerouzic
7bc9461547 chore: make sure commits authors are in th AUTHORS list
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I721957b59746738426f2356056c553d9876bcf22
2025-06-04 12:22:33 -04:00
EstherLerouzic
b0ac41e2d5 fix: PMD was not correctly read from excel or exported from json
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I1069b07dfb62bf94d4f591908c034df4e49ce22a
2025-03-21 15:42:45 +01:00
EstherLerouzic
bce42331c4 fix: improve core.networks module docstrings
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I883987bd8c1b966b9fcab6a87a62d14607d8548d
2025-03-21 10:46:43 +01:00
EstherLerouzic
d5491c9ace fix documentation: harmonize titles
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I827b4dcd1418017d925b63e50f95514dc1a0eed8
2025-03-21 10:00:25 +01:00
EstherLerouzic
689c2fb038 fix minor linter issues
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I22154752198d9c9186d185885ca83d82e8870107
2025-03-21 10:00:25 +01:00
EstherLerouzic
15c912bd72 fix improve docstring for tools.cli_examples
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Id368cb52791090d985e67be09edcc7580939524b
2025-03-21 10:00:25 +01:00
EstherLerouzic
d0c10e8537 fix: improve dosctring and typing in tools.convert
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I6640737f2255867120f829bb9709abce77693147
2025-03-21 10:00:25 +01:00
EstherLerouzic
93186b26fb fix link to example-data files in the documentation
and of the class referenced in the documentation
example-data folder is not accessible from the
generated pages on readthedocs. So use hyperlinks
to the files  github repo.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I135e2cb0b0d28fecffcbcbfec9a9d6c8cb5c7347
2025-03-21 10:00:25 +01:00
EstherLerouzic
49aee5a4e8 feat: improve elements docstring and typing
use sphinx notation for params , attributes and type

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ife5cde24f3f8dfad9f14dccc6e9b41a13ba370f3
2025-03-21 10:00:21 +01:00
EstherLerouzic
1c4da4794d fix: update excel documentation
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I34ae7e7a60d46482df1af538e6977ba9afd09f3a
2025-03-21 09:57:34 +01:00
EstherLerouzic
de42dd4a93 fix: restore rtd theme
and fix the table with the custom css

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ib16c08451aa3faaa06ea85c2b9359fc4e7a015da
2025-03-21 09:57:34 +01:00
JennyLescop
57a5e9732b fix integrate tilt data into conversion
add some tests

Signed-off-by: JennyLescop <jenny.lescop@orange.com>
Change-Id: I4bb9a16b5db7890247568cce9d4b4f81ad2f7d34
2025-03-21 08:22:37 +00:00
Renato Ambrosone
101eb8f969 Define functions for results conversion and load eqpt/topology from dict
Change-Id: I4111f20f59aeef1e25fc8b44028922bbb94dea91
v2.12.1
2025-03-10 16:13:10 +01:00
EstherLerouzic
7ce6650109 feat: move and update documentation on equipment types
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I0f85a059e2393d2d573938bd0804fe49596bbc2d
v2.12
2025-01-30 17:23:18 +01:00
EstherLerouzic
252e67a71e fix: move amp documentation to the docs folder and update it
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ie6c207e3335cbf30b1f5858c21672dff420b9c51
2025-01-30 17:23:18 +01:00
EstherLerouzic
f83869392b feat: improve documentation of the scripts options
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ic68ded41b188cd07cf87f83e31e6d4eea5af5ed9
2025-01-30 17:23:18 +01:00
EstherLerouzic
94a3714aba fix: documentation missing the worker_utils section
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I832b0f0bfdd255396e6c9809273b1171d08c9f60
2025-01-30 17:23:18 +01:00
EstherLerouzic
ccab4835fc fix: Refactor the methods to avoid returning the same value
equipment being a dict, no need to use 'return' to have the changes
applied.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ic5a4247bbaa0b4af3fca5b6cb0a74a2f434b1b6a
2025-01-30 17:23:18 +01:00
EstherLerouzic
e55f7a5d4c Define default in common parts to be used both by cli and API
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I1e9c6aa99fd2896789c73340ccf5c8adf51a5f13
2025-01-30 17:23:18 +01:00
EstherLerouzic
4fda8c6002 use explicit file arguments for additional configs
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I133bb6a2d21d573cf819e1d92b1912dfa87dbfa4
2025-01-30 17:23:18 +01:00
EstherLerouzic
8717156712 feat: Read a list of optional extra equipement files
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: Ic521bbacd38b3bb60da3a364a069abfd1895d337
2025-01-30 17:23:18 +01:00
EstherLerouzic
d2c0836164 Remove default_edfa_config.json dictionary and use parameters.py
But enable the user to still input its own default file with a new
'default_config_from_json' attribute useable in fixed and variable gain
amplifiers.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I773682ae6daa1025007fc051582e779986982838
2025-01-29 18:27:51 +00:00
AndreaDAmico
eac4ba80ea List of collaborative PSE publications added in the docs
Change-Id: I1db6d9fe86004cd5bc8135577421117679cb9965
2025-01-24 08:49:48 +00:00
EstherLerouzic
4ef01d54a5 fix plot bug: do not overwrite the path used for plot
The plot function failed to recognize 'path' as part
of the network due to the reuse of the 'path' variable.
This led to errors when attempting to plot.

Solution is to use a different name for the deepcopy of
path elements used to record the propagation results
'propagated_path'.

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I0351c37de0d74391ebeb68e974b777b1f51572aa
v2.11.1
2025-01-10 11:08:04 +01:00
EstherLerouzic
4b50ee0c2d fix: do not assume 0 dB default value for tilt-target
Instead keep the None value, it user has not stated anything

Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I45fcff92caabbfbe514fbe30deac60426b7eb16b
2024-12-06 16:35:46 +01:00
EstherLerouzic
33a289e22b fix: restore uid info in warning logs
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com>
Change-Id: I2fdd29a4461b250661b1ccaa9737836fc3fe8695
2024-12-06 16:35:46 +01:00