EstherLerouzic
6603a50e78
chore: gnpy yang models
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I68502e76e27b43d2a6f6a5741045df3095fc7ccd
2025-06-30 09:21:39 +02:00
EstherLerouzic
b76c529c0c
chore: import external ietf modules
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I02ed156105736ab538e4d5708d38b497f9479658
2025-06-11 15:05:51 +02:00
EstherLerouzic
7a1b15a916
chore: make sure all python files have the correct header
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ifdd6a566fda74c5b7d417f9d61c51d4d3da07bfd
2025-06-11 15:05:51 +02:00
EstherLerouzic
7bc9461547
chore: make sure commits authors are in th AUTHORS list
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I721957b59746738426f2356056c553d9876bcf22
2025-06-04 12:22:33 -04:00
EstherLerouzic
b0ac41e2d5
fix: PMD was not correctly read from excel or exported from json
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I1069b07dfb62bf94d4f591908c034df4e49ce22a
2025-03-21 15:42:45 +01:00
EstherLerouzic
bce42331c4
fix: improve core.networks module docstrings
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I883987bd8c1b966b9fcab6a87a62d14607d8548d
2025-03-21 10:46:43 +01:00
EstherLerouzic
d5491c9ace
fix documentation: harmonize titles
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I827b4dcd1418017d925b63e50f95514dc1a0eed8
2025-03-21 10:00:25 +01:00
EstherLerouzic
689c2fb038
fix minor linter issues
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I22154752198d9c9186d185885ca83d82e8870107
2025-03-21 10:00:25 +01:00
EstherLerouzic
15c912bd72
fix improve docstring for tools.cli_examples
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Id368cb52791090d985e67be09edcc7580939524b
2025-03-21 10:00:25 +01:00
EstherLerouzic
d0c10e8537
fix: improve dosctring and typing in tools.convert
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I6640737f2255867120f829bb9709abce77693147
2025-03-21 10:00:25 +01:00
EstherLerouzic
93186b26fb
fix link to example-data files in the documentation
...
and of the class referenced in the documentation
example-data folder is not accessible from the
generated pages on readthedocs. So use hyperlinks
to the files github repo.
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I135e2cb0b0d28fecffcbcbfec9a9d6c8cb5c7347
2025-03-21 10:00:25 +01:00
EstherLerouzic
49aee5a4e8
feat: improve elements docstring and typing
...
use sphinx notation for params , attributes and type
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ife5cde24f3f8dfad9f14dccc6e9b41a13ba370f3
2025-03-21 10:00:21 +01:00
EstherLerouzic
1c4da4794d
fix: update excel documentation
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I34ae7e7a60d46482df1af538e6977ba9afd09f3a
2025-03-21 09:57:34 +01:00
EstherLerouzic
de42dd4a93
fix: restore rtd theme
...
and fix the table with the custom css
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ib16c08451aa3faaa06ea85c2b9359fc4e7a015da
2025-03-21 09:57:34 +01:00
JennyLescop
57a5e9732b
fix integrate tilt data into conversion
...
add some tests
Signed-off-by: JennyLescop <jenny.lescop@orange.com >
Change-Id: I4bb9a16b5db7890247568cce9d4b4f81ad2f7d34
2025-03-21 08:22:37 +00:00
Renato Ambrosone
101eb8f969
Define functions for results conversion and load eqpt/topology from dict
...
Change-Id: I4111f20f59aeef1e25fc8b44028922bbb94dea91
v2.12.1
2025-03-10 16:13:10 +01:00
EstherLerouzic
7ce6650109
feat: move and update documentation on equipment types
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I0f85a059e2393d2d573938bd0804fe49596bbc2d
v2.12
2025-01-30 17:23:18 +01:00
EstherLerouzic
252e67a71e
fix: move amp documentation to the docs folder and update it
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ie6c207e3335cbf30b1f5858c21672dff420b9c51
2025-01-30 17:23:18 +01:00
EstherLerouzic
f83869392b
feat: improve documentation of the scripts options
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ic68ded41b188cd07cf87f83e31e6d4eea5af5ed9
2025-01-30 17:23:18 +01:00
EstherLerouzic
94a3714aba
fix: documentation missing the worker_utils section
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I832b0f0bfdd255396e6c9809273b1171d08c9f60
2025-01-30 17:23:18 +01:00
EstherLerouzic
ccab4835fc
fix: Refactor the methods to avoid returning the same value
...
equipment being a dict, no need to use 'return' to have the changes
applied.
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ic5a4247bbaa0b4af3fca5b6cb0a74a2f434b1b6a
2025-01-30 17:23:18 +01:00
EstherLerouzic
e55f7a5d4c
Define default in common parts to be used both by cli and API
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I1e9c6aa99fd2896789c73340ccf5c8adf51a5f13
2025-01-30 17:23:18 +01:00
EstherLerouzic
4fda8c6002
use explicit file arguments for additional configs
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I133bb6a2d21d573cf819e1d92b1912dfa87dbfa4
2025-01-30 17:23:18 +01:00
EstherLerouzic
8717156712
feat: Read a list of optional extra equipement files
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ic521bbacd38b3bb60da3a364a069abfd1895d337
2025-01-30 17:23:18 +01:00
EstherLerouzic
d2c0836164
Remove default_edfa_config.json dictionary and use parameters.py
...
But enable the user to still input its own default file with a new
'default_config_from_json' attribute useable in fixed and variable gain
amplifiers.
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I773682ae6daa1025007fc051582e779986982838
2025-01-29 18:27:51 +00:00
AndreaDAmico
eac4ba80ea
List of collaborative PSE publications added in the docs
...
Change-Id: I1db6d9fe86004cd5bc8135577421117679cb9965
2025-01-24 08:49:48 +00:00
EstherLerouzic
4ef01d54a5
fix plot bug: do not overwrite the path used for plot
...
The plot function failed to recognize 'path' as part
of the network due to the reuse of the 'path' variable.
This led to errors when attempting to plot.
Solution is to use a different name for the deepcopy of
path elements used to record the propagation results
'propagated_path'.
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I0351c37de0d74391ebeb68e974b777b1f51572aa
v2.11.1
2025-01-10 11:08:04 +01:00
EstherLerouzic
4b50ee0c2d
fix: do not assume 0 dB default value for tilt-target
...
Instead keep the None value, it user has not stated anything
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I45fcff92caabbfbe514fbe30deac60426b7eb16b
2024-12-06 16:35:46 +01:00
EstherLerouzic
33a289e22b
fix: restore uid info in warning logs
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I2fdd29a4461b250661b1ccaa9737836fc3fe8695
2024-12-06 16:35:46 +01:00
EstherLerouzic
e593b8c9ec
fix case where there are multiple multiband amps matching the sub amp type
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ibe86499866f2f9e3dfd70b51a33b919d584b812b
2024-12-06 16:35:46 +01:00
EstherLerouzic
94a6f922cd
fix typing
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I0f1621b669b4db833d0760368cd834f3186ee2db
2024-12-06 16:35:46 +01:00
EstherLerouzic
fbe387915b
fix: offset was not correctly taken into account on reversed path
...
TODO: write a test!
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I7ac909bb9b8c9700c3841f133245f17f49ba3467
2024-12-06 16:35:46 +01:00
EstherLerouzic
fce9d1d293
chore: refactor json_io
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: If764ba7b520a060deb855c0b55e17c78fa22f841
2024-12-06 16:35:46 +01:00
EstherLerouzic
a59db8fd12
fix: cli_examples linter issues
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Id7e2f8b7282913b885062a01f1bd018bbc85e39c
2024-12-06 16:35:46 +01:00
EstherLerouzic
de509139b3
fix: linter issues on json_io
...
add docstrings, typing, small fixes
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I01d0fabe5e34103077ec2de829e96829e6202e1e
2024-12-06 16:35:46 +01:00
EstherLerouzic
bb77b3f4a8
fix: remove unused _automatic_spacing
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ie3c2fc226f8a549622933cbd1ba8a6b8be213f92
2024-12-06 16:35:46 +01:00
EstherLerouzic
34c7fd1b60
fix: save autodesign file after autodesign!
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: If1c82c8cb7ff9dbb8bf5c2d5c4b96beaa59dc402
2024-12-06 16:35:46 +01:00
EstherLerouzic
89a962ffaf
fix remove unnecessary else after return
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I61dc58f15c8f03a686437e19a36ac0afe35904e9
2024-12-06 16:35:46 +01:00
EstherLerouzic
1722fbec13
feat: add more warnings on amplifiers
...
when user settings do not match library
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Id387b7781d9637f1d18c453dae75330962229902
2024-12-06 16:35:46 +01:00
EstherLerouzic
e48aa57c35
Improve error reporting by including uid of elements
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ief4125322e4db02765974c43159a014749cdab2e
2024-12-06 16:35:46 +01:00
EstherLerouzic
e3e37b1986
feat: skip path computation when path is explicit
...
and add tests for explicit path
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I95aaf5b56a7ea04f24153d5cb6612cd09401401c
2024-12-06 16:35:46 +01:00
EstherLerouzic
abf42afaf8
fix ci: The macOS-12 environment is deprecated
...
remove this check and add one for The macOS-14 instead
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ief1c990cbc67ec4d7912404c24d67f9f2fa6d96e
2024-12-06 16:35:46 +01:00
EstherLerouzic
310995045e
fix: linter issues in convert and service_sheet
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I5f7490ed61b53cea8d2923a8a54d38b3fbb5fa0a
2024-12-06 16:35:43 +01:00
EstherLerouzic
c840bb1a44
Improve test coverage on ila constraint cases
...
explicitely check the corrections for all cases
ila defined in eqpt or not,
ila defined on the link with same direction as request or not
constraint loose or strict
several or one ila in the OMS
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I4d4b5167e7327c9aea4b13879f4e00d30e60d643
2024-11-25 17:07:36 +01:00
EstherLerouzic
4b6f4af3a5
Refactor to reduce cognitive complexity
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ia9992ebbe06498ed53b3987edd4eb139d960ff75
2024-11-25 17:07:33 +01:00
EstherLerouzic
dc68d38293
fix ila names
...
auto design were changed long ago and these functions did not
apply the changes. Besides there was a confusion between request_element
class where loose is a string, and PathRequest from topology.requests
where loose_list is a list of strings.
This patch corrects the naming and also the tests,
because it used the wrong class to gererate xls services
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I564b77576459d6cb47767398a2db8138ba6ad1e4
2024-11-25 16:55:25 +01:00
EstherLerouzic
defe3bee5c
feat: documentation for ROADM excel sheet input
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Ie662015c9cd0a90aff46c63fce47d678ffe1d4db
2024-11-25 12:09:14 +01:00
EstherLerouzic
32adc0fc53
feat: enables reading per degree impairment from xls input
...
- read per degre roadm-path impairment from roadm sheet
add additional optional columns: type_variety and 'from degrees'
and 'from degree to degree impairment id'
'from degrees' can contain a list of degrees separated with ' | ', then the
'from degree to degree impairment id' must contain a list of ids of the same
length.
Impairment ids are expected to be in the ROADM equipment spec and
from degree must be the previous node (no verification of user input).
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I7d326bb3d4f366835249089e9537747c7d3ec2fd
2024-11-25 12:09:09 +01:00
EstherLerouzic
4796266657
fix bug in roadm to_json: move per_degree_impairments in params
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: I75ed610f201608a3cb651e8c0604de444113bc25
2024-11-25 08:55:00 +01:00
EstherLerouzic
c35104c184
Add documentation for multiband
...
Signed-off-by: EstherLerouzic <esther.lerouzic@orange.com >
Change-Id: Iadf6d9edd8c67c1389c4a0d482466a8c52198621
v2.11
2024-11-21 09:26:51 +01:00