mirror of
https://github.com/optim-enterprises-bv/openstack-helm-infra.git
synced 2026-01-10 17:31:32 +00:00
b1a247e7f5
If labels are not specified on a Job, kubernetes defaults them to include the labels of their underlying Pod template. Helm 3 injects metadata into all resources [0] including a `app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes sees a Job's labels they are no longer empty and thus do not get defaulted to the underlying Pod template's labels. This is a problem since Job labels are depended on by - Armada pre-upgrade delete hooks - Armada wait logic configurations - kubernetes-entrypoint dependencies Thus for each Job template this adds labels matching the underlying Pod template to retain the same labels that were present with Helm 2. [0]: https://github.com/helm/helm/pull/7649 Change-Id: I3b6b25fcc6a1af4d56f3e2b335615074e2f04b6d
==================== Openstack-Helm-Infra ==================== Mission ------- The goal of OpenStack-Helm-Infra is to provide charts for services or integration of third-party solutions that are required to run OpenStack-Helm. For more information, please refer to the OpenStack-Helm repository_. .. _repository: https://github.com/openstack/openstack-helm Communication ------------- * Join us on `IRC <irc://chat.oftc.net/openstack-helm>`_: #openstack-helm on oftc * Community `IRC Meetings <http://eavesdrop.openstack.org/#OpenStack-Helm_Team_Meeting>`_: [Every Tuesday @ 3PM UTC], #openstack-meeting-alt on oftc * Meeting Agenda Items: `Agenda <https://etherpad.openstack.org/p/openstack-helm-meeting-agenda>`_ * Join us on `Slack <https://kubernetes.slack.com/messages/C3WERB7DE/>`_ - #openstack-helm Contributing ------------ We welcome contributions. Check out `this <CONTRIBUTING.rst>`_ document if you would like to get involved.