scottk/twenty
1
0
Fork 0
mirror of https://github.com/lingble/twenty.git synced 2025-10-29 20:02:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Phone field migration][fix] Update field label (#7247)

Browse Source
This commit is contained in:
Marie
2024-09-25 14:06:03 +02:00
committed by GitHub
parent 49b5e53ceb
commit 97ce100fa2
1 changed files with 26 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
packages/twenty-server/src/database/commands/upgrade-version/0-32/0-32-migrate-phone-fields-to-phones.command.ts
View File

@@ -153,25 +153,24 @@ export class MigratePhoneFieldsToPhonesCommand extends ActiveWorkspacesCommandRu
const workspaceId = standardPersonPhoneField.workspaceId;
try {
let standardPersonPhonesFieldType =
let standardPersonPhonesField =
await this.fieldMetadataRepository.findOneBy({
workspaceId,
standardId: PERSON_STANDARD_FIELD_IDS.phones,
});
if (!standardPersonPhonesFieldType) {
standardPersonPhonesFieldType =
await this.fieldMetadataService.createOne({
...deprecatedPhoneFieldWithoutId,
label: 'Phones',
type: FieldMetadataType.PHONES,
defaultValue: null,
name: 'phones',
} satisfies CreateFieldInput);
if (!standardPersonPhonesField) {
standardPersonPhonesField = await this.fieldMetadataService.createOne({
...deprecatedPhoneFieldWithoutId,
label: 'Phones',
type: FieldMetadataType.PHONES,
defaultValue: null,
name: 'phones',
} satisfies CreateFieldInput);
await this.viewService.removeFieldFromViews({
workspaceId: workspaceId,
fieldId: standardPersonPhonesFieldType.id,
fieldId: standardPersonPhonesField.id,
});
}
@@ -181,6 +180,13 @@ export class MigratePhoneFieldsToPhonesCommand extends ActiveWorkspacesCommandRu
workspaceSchemaName,
});
// Add (deprecated) to Phone field label
await this.fieldMetadataService.updateOne(standardPersonPhoneField.id, {
id: standardPersonPhoneField.id,
workspaceId: standardPersonPhoneField.workspaceId,
label: 'Phone (deprecated)',
});
// Add new phones field to views and hide deprecated phone field
const viewFieldRepository =
await this.twentyORMGlobalManager.getRepositoryForWorkspace<ViewFieldWorkspaceEntity>(
@@ -198,7 +204,7 @@ export class MigratePhoneFieldsToPhonesCommand extends ActiveWorkspacesCommandRu
await this.viewService.addFieldToViews({
workspaceId: workspaceId,
fieldId: standardPersonPhonesFieldType.id,
fieldId: standardPersonPhonesField.id,
viewsIds: viewFieldsWithDeprecatedPhoneField
.filter((viewField) => viewField.viewId !== null)
.map((viewField) => viewField.viewId as string),
@@ -213,6 +219,7 @@ export class MigratePhoneFieldsToPhonesCommand extends ActiveWorkspacesCommandRu
},
[],
),
size: 150,
});
await this.viewService.removeFieldFromViews({
@@ -248,6 +255,13 @@ export class MigratePhoneFieldsToPhonesCommand extends ActiveWorkspacesCommandRu
workspaceId,
);
}
// Revert Phone field label (remove (deprecated))
await this.fieldMetadataService.updateOne(standardPersonPhoneField.id, {
id: standardPersonPhoneField.id,
workspaceId: standardPersonPhoneField.workspaceId,
label: 'Phone',
});
} finally {
await workspaceQueryRunner.release();
}