scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-30 02:02:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: fix empty tooltip rendering when no creation time (#19971)

Browse Source 
* fix empty tooltip for no creation time

* remove extra space
This commit is contained in:
claire bontempo
2023-04-04 10:31:49 -06:00
committed by GitHub
parent a19322d575
commit 40b57ed189
3 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
ui/app/templates/components/secret-form-show.hbs
View File

@@ -46,17 +46,19 @@
Value
</div>
<div class="th column justify-right" data-test-created-time>
<ToolTip @verticalPosition="above" @horizontalPosition="center" as |T|>
<T.Trigger data-test-tooltip-trigger tabindex="-1" data-test-created-time>
Version created
{{date-format @modelForData.createdTime "MMM dd, yyyy hh:mm a"}}
</T.Trigger>
<T.Content @defaultClass="tool-tip smaller-font">
<div class="box" data-test-hover-copy-tooltip-text>
{{@modelForData.createdTime}}
</div>
</T.Content>
</ToolTip>
{{#if @modelForData.createdTime}}
<ToolTip @verticalPosition="above" @horizontalPosition="center" as |T|>
<T.Trigger data-test-tooltip-trigger tabindex="-1">
Version created
{{date-format @modelForData.createdTime "MMM dd, yyyy hh:mm a"}}
</T.Trigger>
<T.Content @defaultClass="tool-tip smaller-font">
<div class="box" data-test-hover-copy-tooltip-text>
{{@modelForData.createdTime}}
</div>
</T.Content>
</ToolTip>
{{/if}}
</div>
</div>
</div>

1
ui/tests/acceptance/secrets/backend/cubbyhole/secret-test.js
View File

@@ -46,6 +46,7 @@ module('Acceptance | secrets/cubbyhole/create', function (hooks) {
'vault.cluster.secrets.backend.show',
'redirects to the show page'
);
assert.dom('[data-test-created-time]').hasText('', 'it does not render created time if blank');
assert.ok(showPage.editIsPresent, 'shows the edit button');
});
});

2
ui/tests/acceptance/secrets/backend/kv/secret-test.js
View File

@@ -290,7 +290,7 @@ module('Acceptance | secrets/secret/create, read, delete', function (hooks) {
await editPage.createSecret(secretPath, 'foo', 'bar');
await click('[data-test-popup-menu-trigger="version"]');
assert.dom('[ data-test-created-time]').includesText('Version created ', 'shows version created time');
assert.dom('[data-test-created-time]').includesText('Version created ', 'shows version created time');
await click('[data-test-version-history]');