CLI: Fix erroneous warning when reading from stdin (#17252)

command/base_helpers.go

@@ -296,7 +296,8 @@ func parseFlagFile(raw string) (string, error) {
 func generateFlagWarnings(args []string) string {
 	var trailingFlags []string
 	for _, arg := range args {
-		if !strings.HasPrefix(arg, "-") {
+		// "-" can be used where a file is expected to denote stdin.
+		if !strings.HasPrefix(arg, "-") || arg == "-" {
 			continue
 		}
 

command/base_helpers_test.go

@@ -262,6 +262,10 @@ func TestArgWarnings(t *testing.T) {
 			[]string{"--x=" + globalFlagDetailed},
 			"--x=" + globalFlagDetailed,
 		},
+		{
+			[]string{"policy", "write", "my-policy", "-"},
+			"",
+		},
 	}
 
 	for _, tc := range cases {