scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-29 17:52:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix test that breaks when VersionMetadata is set by compiler (#23883)

Browse Source
This commit is contained in:
Marc Boudreau
2023-10-27 12:21:21 -04:00
committed by GitHub
parent 425b1e333d
commit 987294660b
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
version/version_test.go
View File

@@ -9,23 +9,26 @@ import (
"github.com/stretchr/testify/assert"
)
func replaceVersion(v, vp string) func() {
func replaceVersion(v, vp, vm string) func() {
origV := Version
origVP := VersionPrerelease
origVM := VersionMetadata
Version = v
VersionPrerelease = vp
VersionMetadata = vm
return func() {
Version = origV
VersionPrerelease = origVP
VersionMetadata = origVM
}
}
func TestGetVersion(t *testing.T) {
// This test cannot be parallelized because it messes with some global
// variables that determine the version information.
restoreVersionFunc := replaceVersion("1.2.3", "")
restoreVersionFunc := replaceVersion("1.2.3", "", "")
defer restoreVersionFunc()
// Test the general case
@@ -48,14 +51,14 @@ func TestGetVersion(t *testing.T) {
func TestVersionNumber(t *testing.T) {
// This test cannot be parallelized because it messes with some global
// variables that determine the version information.
restoreVersionFunc := replaceVersion("unknown", "unknown")
restoreVersionFunc := replaceVersion("unknown", "unknown", "")
defer restoreVersionFunc()
// Test the unknown version case
vi := GetVersion()
assert.Equal(t, "(version unknown)", vi.VersionNumber())
replaceVersion("1.2.3", "")
replaceVersion("1.2.3", "", "")
// Test the pre-release case
vi = GetVersion()
@@ -74,7 +77,7 @@ func TestVersionNumber(t *testing.T) {
func TestFullVersionNumber(t *testing.T) {
// This test cannot be parallelized because it messes with some global
// variables that determine the version information.
restoreVersionFunc := replaceVersion("unknown", "unknown")
restoreVersionFunc := replaceVersion("unknown", "unknown", "")
defer restoreVersionFunc()
// Test the unknown version case
@@ -82,7 +85,7 @@ func TestFullVersionNumber(t *testing.T) {
assert.Equal(t, "Vault (version unknown)", vi.FullVersionNumber(false))
// Test the no pre-release, metadata, revision, build date case
replaceVersion("1.2.3", "")
replaceVersion("1.2.3", "", "")
vi = GetVersion()
assert.Equal(t, "Vault v1.2.3", vi.FullVersionNumber(false))