Commit Graph

17340 Commits

Author SHA1 Message Date
hc-github-team-secure-vault-core
3388dab4e6 backport of commit 547bff752e (#23320) 2023-09-27 16:03:40 -04:00
hc-github-team-secure-vault-core
4450198a7e enos: remove old initial version from upgrades (#23323) (#23325)
* Remove old initial versions from the upgrade scenario as they're
  unreliable.
* Ensure that shellcheck is available on runners for linting job.

Signed-off-by: Ryan Cragun <me@ryan.ec>
2023-09-27 19:33:28 +00:00
claire bontempo
690d568b3b fix typo (#23328) 2023-09-27 18:54:11 +00:00
Ryan Cragun
940272de0f Backport [QT-602] Run proxy and agent test scenarios (#23176) into release/1.13.x (#23303)
* [QT-602] Run `proxy` and `agent` test scenarios (#23176)

Update our `proxy` and `agent` scenarios to support new variants and
perform baseline verification and their scenario specific verification.
We integrate these updated scenarios into the pipeline by adding them
to artifact samples.

We've also improved the reliability of the `autopilot` and `replication`
scenarios by refactoring our IP address gathering. Previously, we'd ask
vault for the primary IP address and use some Terraform logic to determine
followers. The leader IP address gathering script was also implicitly
responsible for ensuring that a found leader was within a given group of
hosts, and thus waiting for a given cluster to have a leader, and also for
doing some arithmetic and outputting `replication` specific output data.
We've broken these responsibilities into individual modules, improved their
error messages, and fixed various races and bugs, including:
* Fix a race between creating the file audit device and installing and starting
  vault in the `replication` scenario.
* Fix how we determine our leader and follower IP addresses. We now query
  vault instead of a prior implementation that inferred the followers and sometimes
  did not allow all nodes to be an expected leader.
* Fix a bug where we'd always always fail on the first wrong condition
  in the `vault_verify_performance_replication` module.

We also performed some maintenance tasks on Enos scenarios  byupdating our
references from `oss` to `ce` to handle the naming and license changes. We
also enabled `shellcheck` linting for enos module scripts.

* Rename `oss` to `ce` for license and naming changes.
* Convert template enos scripts to scripts that take environment
  variables.
* Add `shellcheck` linting for enos module scripts.
* Add additional `backend` and `seal` support to `proxy` and `agent`
  scenarios.
* Update scenarios to include all baseline verification.
* Add `proxy` and `agent` scenarios to artifact samples.
* Remove IP address verification from the `vault_get_cluster_ips`
  modules and implement a new `vault_wait_for_leader` module.
* Determine follower IP addresses by querying vault in the
  `vault_get_cluster_ips` module.
* Move replication specific behavior out of the `vault_get_cluster_ips`
  module and into it's own `replication_data` module.
* Extend initial version support for the `upgrade` and `autopilot`
  scenarios.

We also discovered an issue with undo_logs that has been described in
the VAULT-20259. As such, we've disabled the undo_logs check until
it has been fixed.


* actions: fix actionlint error and linting logic (#23305)
* enos: don't attempt to use the vault proxy command before 1.14

---------

Signed-off-by: Ryan Cragun <me@ryan.ec>
2023-09-27 10:53:35 -06:00
hc-github-team-es-release-engineering
e9f61d3085 Bumped product version to 1.13.9. 2023-09-26 15:28:48 -04:00
hc-github-team-secure-vault-core
4c785b0584 backport of commit 1d61aeb8ae (#23251)
Co-authored-by: Sergey Kutovoy <kutovoy.s@gmail.com>
v1.13.8
2023-09-22 15:38:46 +00:00
hc-github-team-secure-vault-core
5c739d6806 backport of commit 758de878d6 (#23220)
Co-authored-by: mickael-hc <86245626+mickael-hc@users.noreply.github.com>
2023-09-21 17:00:26 +00:00
Chelsea Shaw
2e7dc430f2 UI: Show unsupported screen if replication unsupported (#23178) (#23214) 2023-09-21 11:35:54 -05:00
hc-github-team-secure-vault-core
c19522fef5 backport of commit 55414e6a73 (#23197)
Co-authored-by: Aram Mirzadeh <aram535@users.noreply.github.com>
2023-09-20 14:20:48 -07:00
hc-github-team-secure-vault-core
7a0f9fe25f backport of UI: handle control group error on SSH (#23033)
Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
2023-09-20 10:49:52 -05:00
hc-github-team-secure-vault-core
2b81921e7b backport of commit c73eacbaf6 (#23173)
Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com>
2023-09-19 19:48:10 +00:00
Hamid Ghaf
1e4f08b75e fix: Fail in goroutine after tests have completed (#23158) (#23164)
* fix panic: Fail in goroutine after TestProxy_Config_ReloadTls has completed

* fix proxy test

* feedback

* track the command output code and stdout/err
2023-09-19 16:07:47 +00:00
Ryan Cragun
db1c24d904 test: wait for nc to be listening before enabling auditor (#23142) (#23151)
Rather than assuming a short sleep will work, we instead wait until netcat is listening of the socket. We've also configured the netcat listener to persist after the first connection, which allows Vault and us to check the connection without the process closing.

As we implemented this we also ran into AWS issues in us-east-1 and us-west-2, so we've changed our deploy regions until those issues are resolved.

Signed-off-by: Ryan Cragun <me@ryan.ec>
2023-09-18 15:10:12 -06:00
hc-github-team-secure-vault-core
869c5bf491 backport of commit 2a46d492a3 (#23146)
Co-authored-by: Nicola Kabar <nicolaka@gmail.com>
2023-09-18 12:44:26 -07:00
hc-github-team-secure-vault-core
a78fe24e77 backport of commit 3f9b6075aa (#23126)
Backport of UI: add SSH role attribute allowed_domains_template
Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
2023-09-18 15:39:51 +00:00
hc-github-team-secure-vault-core
db50803a1f backport of UI: Handle error from ResponseWithCode (#23115)
Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
2023-09-15 15:37:58 -05:00
hc-github-team-es-release-engineering
b11c3babe4 Bumped product version to 1.13.8. 2023-09-15 08:11:43 -04:00
hc-github-team-secure-vault-core
44e68c7f5b Add known issues around transit managed keys (#23080) (#23099)
* Add known issues around transit managed keys

 - Document known issue around managed key encryption failure with Cloud KMS backed keys and the failure to sign with managed keys

* Fix filename typos

* Update website/content/partials/known-issues/transit-managed-keys-sign-fails.mdx



* Update website/content/partials/known-issues/transit-managed-keys-panics.mdx



* Apply PR feedback

* Missed new line to force error on new-line.

---------

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
2023-09-14 15:02:16 -04:00
hc-github-team-secure-vault-core
3dfe426b81 backport of commit 37215ae311 (#23091)
Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>
2023-09-14 18:43:33 +00:00
hc-github-team-secure-vault-core
693ed35968 backport of commit 854ea77f9e (#23082)
Co-authored-by: Meggie <meggie@hashicorp.com>
2023-09-14 13:21:18 -04:00
hc-github-team-secure-vault-core
410289467f backport of commit f0fb07b0b2 (#23070)
Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
2023-09-13 18:49:23 -04:00
hc-github-team-secure-vault-core
9bc9bd3a7e backport of commit 15a50b8959 (#23057)
Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
2023-09-13 15:58:27 -04:00
hc-github-team-secure-vault-core
c4a31dacf0 Backport of Clean up unused CRL entries when issuer is removed into release/1.13.x (#23029)
* backport of commit e2ff1f1c71 (#23030)

Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>

* backport of commit 293e8b8ac5 (#23045)

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>

* Fix call of crlBuilder.rebuild

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

---------

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
2023-09-13 13:57:36 +00:00
hc-github-team-secure-vault-core
af5c376598 backport of commit 5a83838f1d (#23019)
Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>
2023-09-13 09:15:35 -04:00
hc-github-team-secure-vault-core
91c9e1e6f4 Backport of UI: [VAULT-18040] List all features in license info into release/1.13.x (#23004)
Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>
2023-09-12 10:20:57 -07:00
Kianna
2e332ecf52 UI: [VAULT-18178] Fix filter/search bug for pki role (#22810) 2023-09-12 08:48:38 -07:00
hc-github-team-secure-vault-core
895eb72029 backport of commit 9a7de066a9 (#22982)
Co-authored-by: Ryan Cragun <me@ryan.ec>
v1.13.7
2023-09-11 21:27:34 +00:00
hc-github-team-secure-vault-core
8a37264de0 backport of commit d634700c9e (#22965)
Co-authored-by: Ryan Cragun <me@ryan.ec>
2023-09-11 18:22:18 +00:00
Ryan Cragun
8ba68ca4c2 test: don't use actions-set-product-version in release testing (#22948) (#22950)
Signed-off-by: Ryan Cragun <me@ryan.ec>
2023-09-08 16:57:06 -06:00
Ryan Cragun
9995ccd003 test: fix release testing from artifactory (#22941) (#22946)
Signed-off-by: Ryan Cragun <me@ryan.ec>
2023-09-08 21:31:11 +00:00
hc-github-team-secure-vault-core
b15098fa96 [QT-506] Use enos scenario samples for testing (#22641) (#22932)
Replace our prior implementation of Enos test groups with the new Enos
sampling feature. With this feature we're able to describe which
scenarios and variant combinations are valid for a given artifact and
allow enos to create a valid sample field (a matrix of all compatible
scenarios) and take an observation (select some to run) for us. This
ensures that every valid scenario and variant combination will
now be a candidate for testing in the pipeline. See QT-504[0] for further
details on the Enos sampling capabilities.

Our prior implementation only tested the amd64 and arm64 zip artifacts,
as well as the Docker container. We now include the following new artifacts
in the test matrix:
* CE Amd64 Debian package
* CE Amd64 RPM package
* CE Arm64 Debian package
* CE Arm64 RPM package

Each artifact includes a sample definition for both pre-merge/post-merge
(build) and release testing.

Changes:
* Remove the hand crafted `enos-run-matrices` ci matrix targets and replace
  them with per-artifact samples.
* Use enos sampling to generate different sample groups on all pull
  requests.
* Update the enos scenario matrices to handle HSM and FIPS packages.
* Simplify enos scenarios by using shared globals instead of
  cargo-culted locals.

Note: This will require coordination with vault-enterprise to ensure a
smooth migration to the new system. Integrating new scenarios or
modifying existing scenarios/variants should be much smoother after this
initial migration.

[0] https://github.com/hashicorp/enos/pull/102

Signed-off-by: Ryan Cragun <me@ryan.ec>
2023-09-08 19:34:27 +00:00
Hamid Ghaf
bf256af40d bump go version to 1.20.8 on 1.13.x (#22935) 2023-09-08 19:16:59 +00:00
hc-github-team-secure-vault-core
e1dee56fd6 Backport of UI: Show error if tool action is not recognized into release/1.13.x (#22829)
* backport of commit 2ca784ad11

---------

Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
Co-authored-by: Chelsea Shaw <cshaw@hashicorp.com>
2023-09-08 16:28:06 +00:00
hc-github-team-secure-vault-core
cdba1eebd0 backport of commit 8c4b4650ae (#22909)
Co-authored-by: Scott Miller <smiller@hashicorp.com>
2023-09-08 10:58:06 -05:00
Scott Miller
8abe3cd68b Reject supplied nonces for non-convergent encryption operations (#22852) (#22901)
* Reject supplied nonces for non-convergent encryption operations (#22852)

Backport to 1.13.x

* need http after all
2023-09-08 09:59:21 -05:00
hc-github-team-secure-vault-core
2eea7faf61 backport of commit 3130e8ba94 (#22867) 2023-09-07 20:01:16 +00:00
Bianca Moreira
df758c4eaa Add administrative namespace docs (#22581) (#22792)
* Add administrative namespace section to namespaces docs
* Tag sys endpoints with restricted admin alert
---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
2023-09-07 09:12:24 -04:00
Sarah Thompson
4a4ac6771b cherrypick of a9a4b0b9ff (#22811) 2023-09-06 18:25:51 +01:00
Scott Miller
3bbcbd4853 Update go-kms-wrapping to get Azure HTTP/2 workaround (1.13.x) (#22769)
* Update go-kms-wrapping to get Azure HTTP/2 workaround (1.13.x)

* changelog

* Revert "Update go-kms-wrapping to get Azure HTTP/2 workaround (1.13.x)"

This reverts commit 17fbce3a79039dbbebab802d35839182b2342642.

* Re-attempt th update of the azure wrapper
2023-09-05 14:52:19 -05:00
hc-github-team-secure-vault-core
9a9f21ff67 backport of commit 4c8cc87794 (#22246)
Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
2023-09-01 13:16:25 -04:00
hc-github-team-secure-vault-core
9042812f82 Backport of Add config value that gives users options to skip calculating role for each lease into release/1.13.x (#22729)
* Add config value that gives users options to skip calculating role for each lease (#22651)

* Add config value that gives users options to skip calculating role for each lease

* add changelog

* change name

* add config for testing

* Update changelog/22651.txt

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>

* update tests, docs and reorder logic in conditional

* fix comment

* update comment

* fix comment again

* Update comments and change if order

* change comment again

* add other comment

* fix tests

* add documentation

* edit docs

* Update http/util.go

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Update vault/core.go

* Update vault/core.go

* update var name

* udpate docs

* Update vault/request_handling.go

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* 1 more docs change

---------

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* remove wrong part of cherry-pick

---------

Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
2023-09-01 08:07:21 -05:00
hc-github-team-secure-vault-core
fa9c963140 Backport of Add worker pool for LDAP group lookup into release/1.13.x (#22703)
* Add worker pool for LDAP group lookup (#22659)

* Add worker pool for LDAP group lookup

* changelog

* Add lock

* derefAliases disappeared

* Remove deref

* fmt

---------

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
2023-09-01 12:25:28 +00:00
hc-github-team-secure-vault-core
716aa13113 backport of commit 727c73cbd1 (#22685)
Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com>
2023-08-31 13:34:58 +00:00
Alexander Scheel
27e1aedcb5 Update version to 1.13.7 (#22667)
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
2023-08-31 09:03:53 -04:00
hc-github-team-secure-vault-core
06476ec0bc backport of commit bd3596610f (#22661)
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
2023-08-30 12:39:10 -07:00
hc-github-team-secure-vault-core
bdd61d4175 backport of commit c4a8b23d93 (#22638)
Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
2023-08-30 15:27:25 +00:00
hc-github-team-secure-vault-core
bd039945fb backport of commit ce2851543f (#22632)
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
2023-08-29 17:49:43 -07:00
hc-github-team-secure-vault-core
8691911575 backport of commit 7cd0dd97d2 (#22625)
Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
2023-08-29 16:18:28 -05:00
hc-github-team-secure-vault-core
7894fa69e1 backport of commit 9b78fd64ac (#22622)
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
2023-08-29 15:43:05 -05:00
hc-github-team-secure-vault-core
da53ee433a backport of commit d0997baebc (#22607)
Co-authored-by: Adam Rowan <92474478+bear359@users.noreply.github.com>
2023-08-29 09:03:02 -07:00