Fixed SMS validation

This commit is contained in:
stephb9959
2021-10-13 08:46:56 -07:00
parent 84238702cf
commit 66832e1581
3 changed files with 5 additions and 3 deletions

2
build
View File

@@ -1 +1 @@
47
48

View File

@@ -174,7 +174,9 @@ namespace OpenWifi {
} else if(NewUser.userTypeProprietaryInfo.mfa.method=="email") {
Existing.userTypeProprietaryInfo.mfa.method=NewUser.userTypeProprietaryInfo.mfa.method;
} else {
return BadRequest(RESTAPI::Errors::BadMFAMethod);
if(NewUser.userTypeProprietaryInfo.mfa.enabled && Existing.userTypeProprietaryInfo.mfa.method.empty()) {
return BadRequest(RESTAPI::Errors::BadMFAMethod);
}
}
}

View File

@@ -52,7 +52,7 @@ namespace OpenWifi {
auto Challenge = MFAServer::MakeChallenge();
Cache_.emplace_back(SMSValidationCacheEntry{.Number=Number, .Code=Challenge, .UserName=UserName, .Created=Now});
std::string Message = "Please enter the following code on your login screen: " + Challenge;
return Send(Number, Message)==0;
return Send(Number, Message);
}
bool SMSSender::IsNumberValid(const std::string &Number, const std::string &UserName) {