mirror of
https://github.com/outbackdingo/firezone.git
synced 2026-01-27 18:18:55 +00:00
feat(windows): enable crash handling on release builds (#3441)
Since #3263 closed, we could enable crash handling for release builds on Windows, too. This should get rid of a dead code warning in CI:  Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
This commit is contained in:
@@ -20,7 +20,6 @@ const SOCKET_NAME: &str = "dev.firezone.client.crash_handler";
|
||||
/// <https://github.com/EmbarkStudios/crash-handling/blob/main/minidumper/examples/diskwrite.rs>
|
||||
/// Linux has a special `set_ptracer` call that is handy
|
||||
/// MacOS needs a special `ping` call to flush messages inside the crash handler
|
||||
#[cfg(all(debug_assertions, target_os = "windows"))]
|
||||
pub(crate) fn attach_handler() -> Result<CrashHandler> {
|
||||
// Attempt to connect to the server
|
||||
let (client, _server) = start_server_and_connect()?;
|
||||
@@ -39,11 +38,6 @@ pub(crate) fn attach_handler() -> Result<CrashHandler> {
|
||||
Ok(handler)
|
||||
}
|
||||
|
||||
#[cfg(not(debug_assertions))]
|
||||
pub(crate) fn attach_handler() -> Result<CrashHandler> {
|
||||
bail!("crash handling is disabled in release builds for now");
|
||||
}
|
||||
|
||||
/// Main function for the server process, for out-of-process crash handling.
|
||||
///
|
||||
/// The server process seems to be the preferred method,
|
||||
|
||||
Reference in New Issue
Block a user