github-personal/kubernetes
1
0
Fork 0
mirror of https://github.com/outbackdingo/kubernetes.git synced 2026-01-27 10:19:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

hack: fix KUBE_RACE in benchmark-dockerized.sh

Browse Source 
This fixes the following issue in ci-benchmark-scheduler-perf-master:

    malformed import path " ": invalid char ' '

    FAIL	  [setup failed]

Setting the non-empty string with just a space was broken, the right way to
disable the race detector is with an empty KUBE_RACE variable. This worked
before when test-integration.sh unconditionally overwrote the KUBE_RACE
variable and stopped working when 6cb1488 started to keep whatever was
set by the caller.

This then caused an empty string to be passed as additional parameter to "go
test".
This commit is contained in:
Patrick Ohly
2025-06-05 15:08:35 +02:00
parent 7f50c56b1a
commit 036f4bfe28
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
hack/jenkins/benchmark-dockerized.sh
View File

@@ -49,8 +49,9 @@ if [ -n "${KUBE_HACK_TOOLS_GOTOOLCHAIN:-}" ]; then
fi
GOTOOLCHAIN="${hack_tools_gotoolchain}" go -C "${KUBE_ROOT}/hack/tools" install github.com/cespare/prettybench
# Disable the Go race detector.
export KUBE_RACE=" "
# Disable the Go race detector by explicitly setting it to the empty string (= no argument).
# This is also the default, but let's be explicit in case that this changes later.
export KUBE_RACE=""
# Disable coverage report
export KUBE_COVER="n"
export ARTIFACTS=${ARTIFACTS:-"${WORKSPACE}/artifacts"}