scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-28 02:35:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: Remove unused fan channels

Browse Source 
With the PWM interface refactoring, only the CPU fan uses the fan.h
interface.  All other PWM channels (keyboard backlight, etc.) use the
pwm.h interface.  Remove the unused constants, and rename FAN_CH_CPU
to CONFIG_FAN_CH_CPU so it fits with the other fan config options.

No functional changes; just renaming things.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all targets; pass unit tests

Change-Id: I391fbeaf54afcc29a11c2799a4520b7ad8784796
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/170534
Reviewed-by: Vic Yang <victoryang@chromium.org>
This commit is contained in:
Randall Spangler
2013-09-24 16:51:31 -07:00
committed by chrome-internal-fetch
parent eb27bf14d4
commit 20724deae6
14 changed files with 32 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
board/bolt/board.c
View File

@@ -182,8 +182,8 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);
/* PWM channels */
const struct pwm_t pwm_channels[] = {
[PWM_CH_FAN] = {FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_KBLIGHT] = {FAN_CH_KBLIGHT, 0},
[PWM_CH_FAN] = {CONFIG_FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_KBLIGHT] = {4, 0},
};
BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);

8
board/bolt/board.h
View File

@@ -38,6 +38,7 @@
/* External Charger maximum current. */
#define CONFIG_CHARGER_INPUT_CURRENT 5000
#define CONFIG_FAN
#define CONFIG_FAN_CH_CPU 2
#define CONFIG_FAN_RPM_MIN 1000
#define CONFIG_FAN_RPM_MAX 5050
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
@@ -65,17 +66,12 @@ enum module_id {
MODULE_UART,
};
/* PWM channels */
#define FAN_CH_CPU 2 /* CPU fan */
#define FAN_CH_KBLIGHT 4 /* Keyboard backlight */
#define FAN_CH_BL_DISPLAY 0 /* Panel backlight (from PCH, cleaned by EC) */
/* I2C ports */
#define I2C_PORT_BATTERY 0
#define I2C_PORT_CHARGER 0
#define I2C_PORT_LIGHTBAR 1
#define I2C_PORT_THERMAL 5
/* There are only two I2C ports used because battery and charger share a port */
/* There are only 3 I2C ports used because battery and charger share a port */
#define I2C_PORTS_USED 3
/* 13x8 keyboard scanner uses an entire GPIO bank for row inputs */

2
board/falco/board.c
View File

@@ -186,7 +186,7 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);
/* PWM channels */
const struct pwm_t pwm_channels[] = {
[PWM_CH_FAN] = {FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_FAN] = {CONFIG_FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
};
BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);

7
board/falco/board.h
View File

@@ -21,9 +21,10 @@
#define CONFIG_EXTPOWER_FALCO
#define CONFIG_EXTPOWER_GPIO
#define CONFIG_FAN
#define CONFIG_FAN_CH_CPU 2
#define CONFIG_FAN_RPM_MIN 1000
#define CONFIG_FAN_RPM_MAX 5050
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
#define CONFIG_KEYBOARD_BOARD_CONFIG
#define CONFIG_KEYBOARD_PROTOCOL_8042
#define CONFIG_POWER_BUTTON
@@ -48,10 +49,6 @@ enum module_id {
MODULE_UART,
};
/* PWM channels */
#define FAN_CH_CPU 2 /* CPU fan */
#define FAN_CH_BL_DISPLAY 4 /* LVDS backlight (from PCH, cleaned by EC) */
/* I2C ports */
#define I2C_PORT_BATTERY 0
#define I2C_PORT_CHARGER 0

4
board/link/board.c
View File

@@ -184,8 +184,8 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);
/* PWM channels */
const struct pwm_t pwm_channels[] = {
[PWM_CH_FAN] = {FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_KBLIGHT] = {FAN_CH_KBLIGHT, 0},
[PWM_CH_FAN] = {CONFIG_FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_KBLIGHT] = {1, 0},
};
BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);

8
board/link/board.h
View File

@@ -21,9 +21,10 @@
#define CONFIG_CHIPSET_X86
#define CONFIG_EXTPOWER_GPIO
#define CONFIG_FAN
#define CONFIG_FAN_CH_CPU 0
#define CONFIG_FAN_RPM_MIN 1500
#define CONFIG_FAN_RPM_MAX 9300
#define CONFIG_FAN_POWER_GOOD GPIO_PGOOD_5VALW
#define CONFIG_FAN_POWER_GOOD GPIO_PGOOD_5VALW
#define CONFIG_I2C_PASSTHRU_RESTRICTED
#define CONFIG_KEYBOARD_BOARD_CONFIG
#define CONFIG_KEYBOARD_PROTOCOL_8042
@@ -54,11 +55,6 @@ enum module_id {
MODULE_UART,
};
/* Fan PWM channels */
#define FAN_CH_CPU 0 /* CPU fan */
#define FAN_CH_KBLIGHT 1 /* Keyboard backlight */
#define FAN_CH_POWER_LED 5 /* Power adapter LED */
enum adc_channel {
/* EC internal die temperature in degrees K. */
ADC_CH_EC_TEMP = 0,

2
board/peppy/board.c
View File

@@ -178,7 +178,7 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);
/* PWM channels */
const struct pwm_t pwm_channels[] = {
[PWM_CH_FAN] = {FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_FAN] = {CONFIG_FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
};
BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);

7
board/peppy/board.h
View File

@@ -22,10 +22,11 @@
#define CONFIG_CMD_GSV
#define CONFIG_EXTPOWER_GPIO
#define CONFIG_FAN
#define CONFIG_FAN_CH_CPU 2
#define CONFIG_FAN_EN_GPIO GPIO_PP5000_FAN_EN
#define CONFIG_FAN_RPM_MIN 1000
#define CONFIG_FAN_RPM_MAX 5050
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
#define CONFIG_KEYBOARD_BOARD_CONFIG
#define CONFIG_KEYBOARD_PROTOCOL_8042
#define CONFIG_POWER_BUTTON
@@ -50,10 +51,6 @@ enum module_id {
MODULE_UART,
};
/* PWM channels */
#define FAN_CH_CPU 2 /* CPU fan */
#define FAN_CH_BL_DISPLAY 4 /* LVDS backlight (from PCH, cleaned by EC) */
/* I2C ports */
#define I2C_PORT_BATTERY 0
#define I2C_PORT_CHARGER 0

5
board/rambi/board.c
View File

@@ -152,9 +152,10 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);
/* PWM channels */
const struct pwm_t pwm_channels[] = {
[PWM_CH_LED_GREEN] = {FAN_CH_LED_GREEN, 0},
[PWM_CH_LED_RED] = {FAN_CH_LED_RED, 0},
[PWM_CH_LED_GREEN] = {4, 0},
[PWM_CH_LED_RED] = {3, 0},
};
BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);
/* I2C ports */

4
board/rambi/board.h
View File

@@ -51,10 +51,6 @@ enum module_id {
MODULE_UART,
};
/* PWM channels */
#define FAN_CH_LED_GREEN 4 /* LED0 = green */
#define FAN_CH_LED_RED 3 /* LED1 = red */
/* I2C ports */
#define I2C_PORT_BATTERY 0
#define I2C_PORT_CHARGER 0

2
board/slippy/board.c
View File

@@ -176,7 +176,7 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);
/* PWM channels */
const struct pwm_t pwm_channels[] = {
[PWM_CH_FAN] = {FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
[PWM_CH_FAN] = {CONFIG_FAN_CH_CPU, PWM_CONFIG_HAS_RPM_MODE},
};
BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);

7
board/slippy/board.h
View File

@@ -22,9 +22,10 @@
#define CONFIG_CMD_GSV
#define CONFIG_EXTPOWER_GPIO
#define CONFIG_FAN
#define CONFIG_FAN_CH_CPU 2
#define CONFIG_FAN_RPM_MIN 1000
#define CONFIG_FAN_RPM_MAX 5050
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
#define CONFIG_FAN_POWER_GOOD GPIO_PP5000_PGOOD
#define CONFIG_KEYBOARD_BOARD_CONFIG
#define CONFIG_KEYBOARD_PROTOCOL_8042
#define CONFIG_LED_SLIPPY
@@ -50,10 +51,6 @@ enum module_id {
MODULE_UART,
};
/* PWM channels */
#define FAN_CH_CPU 2 /* CPU fan */
#define FAN_CH_BL_DISPLAY 4 /* LVDS backlight (from PCH, cleaned by EC) */
/* I2C ports */
#define I2C_PORT_BATTERY 0
#define I2C_PORT_CHARGER 0

17
chip/lm4/fan.c
View File

@@ -52,7 +52,7 @@ static void fan_set_enabled(int enable)
static int fan_get_rpm_mode(void)
{
return (LM4_FAN_FANCH(FAN_CH_CPU) & 0x0001) ? 0 : 1;
return (LM4_FAN_FANCH(CONFIG_FAN_CH_CPU) & 0x0001) ? 0 : 1;
}
static void fan_set_rpm_mode(int rpm_mode)
@@ -63,24 +63,24 @@ static void fan_set_rpm_mode(int rpm_mode)
if (!was_rpm && rpm_mode) {
/* Enable RPM control */
fan_set_enabled(0);
LM4_FAN_FANCH(FAN_CH_CPU) &= ~0x0001;
LM4_FAN_FANCH(CONFIG_FAN_CH_CPU) &= ~0x0001;
fan_set_enabled(was_enabled);
} else if (was_rpm && !rpm_mode) {
/* Disable RPM mode */
fan_set_enabled(0);
LM4_FAN_FANCH(FAN_CH_CPU) |= 0x0001;
LM4_FAN_FANCH(CONFIG_FAN_CH_CPU) |= 0x0001;
fan_set_enabled(was_enabled);
}
}
static int fan_get_rpm_actual(void)
{
return (LM4_FAN_FANCST(FAN_CH_CPU) & MAX_RPM) * CPU_FAN_SCALE;
return (LM4_FAN_FANCST(CONFIG_FAN_CH_CPU) & MAX_RPM) * CPU_FAN_SCALE;
}
static int fan_get_rpm_target(void)
{
return (LM4_FAN_FANCMD(FAN_CH_CPU) & MAX_RPM) * CPU_FAN_SCALE;
return (LM4_FAN_FANCMD(CONFIG_FAN_CH_CPU) & MAX_RPM) * CPU_FAN_SCALE;
}
static void fan_set_rpm_target(int rpm)
@@ -93,12 +93,12 @@ static void fan_set_rpm_target(int rpm)
if (rpm < 0 || rpm > MAX_RPM)
rpm = MAX_RPM;
LM4_FAN_FANCMD(FAN_CH_CPU) = rpm;
LM4_FAN_FANCMD(CONFIG_FAN_CH_CPU) = rpm;
}
static int fan_get_status(void)
{
return (LM4_FAN_FANSTS >> (2 * FAN_CH_CPU)) & 0x03;
return (LM4_FAN_FANSTS >> (2 * CONFIG_FAN_CH_CPU)) & 0x03;
}
static const char * const human_status[] = {
"not spinning", "changing", "locked", "frustrated"
@@ -114,7 +114,8 @@ static int fan_is_stalled(void)
return 0;
/* Check for stall condition */
return (((LM4_FAN_FANSTS >> (2 * FAN_CH_CPU)) & 0x03) == 0) ? 1 : 0;
return (((LM4_FAN_FANSTS >> (2 * CONFIG_FAN_CH_CPU)) & 0x03) == 0) ?
1 : 0;
}
/*****************************************************************************/

3
include/config.h
View File

@@ -316,6 +316,9 @@
/* Compile support for PWM control of cooling fans */
#undef CONFIG_FAN
/* Fan channel (not PWM channel) for the CPU fan */
#undef CONFIG_FAN_CPU_CH
/* Name of active high GPIO to control power to the cooling fan */
#undef CONFIG_FAN_EN_GPIO