scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-29 18:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the keyboard "cold reset" hack

Browse Source 
This was needed because we could not do a clean
reset with CF9 and were relying on the keyboard
reset pulse to trigger a cold reset.

However it has the downside of causing a kernel
panic to be a cold reset and the kernel panic
information in memory is lost.

Now that we have a VR workaround this hack can
be disabled and the keyboard can instead issue
a warm reset.

BUG=chrome-os-partner:11036
TEST=manual

1) install this EC on a Link device and boot
2) log in and execute "echo panic > /proc/breakme"
3) after reboot look for kernel entry in /var/spool/crash

Change-Id: I1134618f0a202d37aaae69a1d857fa8853a7e52c
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/27722
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Duncan Laurie
2012-07-17 16:24:16 -07:00
committed by Gerrit
parent 60e7844818
commit 2bee304abd
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
common/keyboard.c
View File

@@ -596,10 +596,7 @@ int handle_keyboard_command(uint8_t command, uint8_t *output)
#ifdef CONFIG_TASK_X86POWER
case I8042_SYSTEM_RESET:
/* Trigger a cold reset, since that also resets the TPM. If we
* just trigger a warm reset, that doesn't assert PLTRST# and
* the TPM is not reset. See crosbug.com/p/8379. */
x86_power_reset(1);
x86_power_reset(0);
break;
#endif