scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-28 10:45:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: host: Fix sbc_charging_v2 test failure

Browse Source 
sb_i2c_xfer() assumes 'out' is a valid pointer, which is only true if
out_size is non-zero.

BUG=chrome-os-partner:51207
BRANCH=glados
TEST=`make buildall -j` w/
https://chromium-review.googlesource.com/#/c/342630/

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Ia22dcca2b5318b4d69c7afa49f5c8891ab329bd1
Reviewed-on: https://chromium-review.googlesource.com/342635
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@google.com>
This commit is contained in:
Shawn Nematbakhsh
2016-05-05 09:53:28 -07:00
committed by chrome-bot
parent 8321eed87b
commit 2c162ddade
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
board/host/battery.c
View File

@@ -17,7 +17,7 @@ static uint16_t mock_smart_battery[SB_MANUFACTURER_DATA + 1];
int sb_i2c_xfer(int port, int slave_addr, const uint8_t *out, int out_size,
uint8_t *in, int in_size, int flags)
{
if (out_size == 0 && in_size == 0)
if (out_size == 0)
return EC_SUCCESS;
if (port != I2C_PORT_BATTERY || slave_addr != BATTERY_ADDR)