scottk/OpenNetworkLinux
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenNetworkLinux.git synced 2026-01-06 23:32:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

[as5916-54xks] Enhance code per comment by Billie

Browse Source
This commit is contained in:
brandon_chuang
2019-01-21 15:04:19 +08:00
parent 3198710006
commit 59c21f2959
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/platforms/accton/x86-64/x86-64-accton-as5916-54xks/modules/builds/x86-64-accton-as5916-54xks-sfp.c
View File

@@ -1439,26 +1439,27 @@ static ssize_t set_phy(struct device *dev, struct device_attribute *da,
/* Parsing command into tokens */
token = __strtok_r(command, delim, &last);
while (token != NULL) {
long param = 0;
unsigned long param = 0;
status = kstrtol(token, 0, &param);
status = kstrtoul(token, 0, &param);
if (status) {
return status;
goto exit_free;
}
/* Validate each param length */
if (param > 0xFF) {
return -EINVAL;
status = -EINVAL;
goto exit_free;
}
ipmi_phy_tx_data[i++] = param;
token = __strtok_r(NULL, delim, &last);
}
/* Validate command */
if (i <= IPMI_PHY_HEADER_LEN || (i != IPMI_PHY_DATA_LEN(wdata.ipmi_tx_data[2]))) {
return -EINVAL;
status = -EINVAL;
goto exit_free;
}
mutex_lock(&data->update_lock);
@@ -1468,20 +1469,22 @@ static ssize_t set_phy(struct device *dev, struct device_attribute *da,
(unsigned char *)&wdata,
IPMI_PHY_DATA_LEN(wdata.ipmi_tx_data[2]), NULL, 0);
if (unlikely(status != 0)) {
goto exit;
goto exit_lock;
}
if (unlikely(data->ipmi.rx_result != 0)) {
status = -EIO;
goto exit;
goto exit_lock;
}
status = count;
exit:
exit_lock:
mutex_unlock(&data->update_lock);
return status;
exit_free:
kfree(command);
return status;
}
/*************************************************************************************