Jan Kundrát
5af195bd2b
Remove unused imports
...
Change-Id: I66174048a9eaab0f79ba4c3b1d31ef4dc9c2009b
2020-04-30 17:30:55 +02:00
AndreaDAmico
80eced85ec
Refactoring with some incompatible changes
...
Please be advised that there were incompatible changes in the Raman
options, including a `s/phase_shift_tollerance/phase_shift_tolerance/`.
Signed-off-by: AndreaDAmico <andrea.damico@polito.it >
Co-authored-by: EstherLerouzic <esther.lerouzic@orange.com >
Co-authored-by: Jan Kundrát <jan.kundrat@telecominfraproject.com >
2019-12-17 11:51:09 +01:00
Jan Kundrát
54bf426472
Raman: linear interpolation of channel NLI
...
The Raman engine computes NLI just for a subset of channels; this is an
important speed optimization because the computation is rather CPU
heavy. However, the code just left NaNs in place for NLI of those
channels which were not explicitly simulated.
This is wrong because these NaNs propagate all the way to the total
input/output powers per the whole spectrum, etc, leading to NaNs being
shown to the user.
This patch uses a very simple linear approximation just in order to
prevent these NaNs.
fixes #288
2019-09-02 21:10:20 +02:00
Jan Kundrát
81585c5a86
Unify implementations of psi computation
...
Both of these places referred to "eq. 123 from arXiv:1209.0394", the
only difference (apart from the source of the input parameters, beta2
and asymptotic_length) was calling the two branches "SCI" and "XCI" vs.
"SPM" and "XPM".
In this commit I've only moved the code to a single implementation. The
input data are still being read from the same parameters, of course.
2019-08-08 13:38:23 +02:00
Jan Kundrát
2f52c11589
More intuitive name for list of channels where Raman gain is computed
2019-08-08 11:34:33 +02:00
Jan Kundrát
0f4d8573cf
Move Raman parameter propagation to gnpy.core.network
...
Conceptually, this is just about propagating the input parameters (which
drive the simulation) into all RamanFiber instances. The network module
already contains similar functions, let's move it there.
2019-08-08 11:19:25 +02:00
Jan Kundrát
36ca22db9b
Raman: use logging instead of debugging print()s
2019-08-07 23:31:20 +02:00
Jan Kundrát
4e786a32b5
Merge branch 'no-convenience-access' into raman
...
This required some adaptations in the new Raman code now that the
property aliases are gone.
2019-08-06 11:43:16 +02:00
Alessio Ferrari
8a1001cd40
dynamic evaluation of threshold frequency between near XPM and far XPM
2019-08-01 14:42:47 +02:00
Alessio Ferrari
beb2b576aa
changed output of propagate_raman_fiber to return a list
2019-08-01 14:41:40 +02:00
Alessio Ferrari
8f3923046b
alpha0 computation moved from NLI solver to Fiber Params
2019-08-01 11:36:32 +02:00
Alessio Ferrari
88c68d2065
introduced classes for the parameters
2019-08-01 11:32:07 +02:00
Alessio Ferrari
8bcde72a10
changes on variable names to be more clear
2019-08-01 10:49:25 +02:00
Alessio Ferrari
4653dbcf4b
introduced a faster computation for XPM
2019-08-01 10:48:02 +02:00
Alessio Ferrari
2eed891f8d
new variable names for SPM and XPM
2019-07-31 11:29:25 +02:00
Alessio Ferrari
c0b84e84c8
double underscore replaced with single one for some attributes
2019-07-31 11:24:16 +02:00
Alessio Ferrari
2c20fd3f9f
strings 'XPM' and 'SPM' removed while computing NLI, now it is implicit
2019-07-31 11:20:34 +02:00
Alessio Ferrari
f4db56ca29
minor fix to comments
2019-07-31 11:18:46 +02:00
Alessio Ferrari
e29f8485ea
integration of the GGN-model with spectral separation
2019-06-18 13:31:01 +02:00
Alessio Ferrari
ff82c5171b
propagate_raman_fiber function introduced
2019-06-11 13:39:41 +02:00
Alessio Ferrari
f9bd6310f1
introcude NLI solver
2019-06-11 13:38:39 +02:00
Alessio Ferrari
471eab126e
fix raman solver parameters
2019-06-11 13:38:05 +02:00
Alessio Ferrari
fd406c106b
gn model introduced in the science utils module
2019-06-03 16:33:26 +02:00
Alessio Ferrari
3f7180c706
configure_network function created to configure the RamanFiber.sim_params in a network
2019-05-28 11:35:42 +02:00
Alessio Ferrari
c0fda8c3a2
fix to Raman solver
2019-05-27 17:09:34 +02:00
Alessio Ferrari
0b2ee6fdaf
add Raman solver
2019-05-22 12:05:51 +02:00
Alessio Ferrari
d86bea80d3
fix load_sim_params
2019-05-22 11:00:02 +02:00
Alessio Ferrari
efae43f122
utility to load sim params from json
2019-05-22 10:26:24 +02:00
Alessio Ferrari
45e8c8692b
add science utils module
2019-05-22 10:09:27 +02:00
