scottk/vault
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/vault.git synced 2025-10-30 18:17:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove t.Parallel() due to initialization race (#18751)

Browse Source 
Using RunCommand(...) to set format to JSON for PKI HC tests results in
multiple initCommands(...) being called, overwriting the same global
variable. Nobody else calls the test suite in this way, so remove
t.Parallel() as the CLI isn't really meant to be called in parallel and
there might be other issues.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This commit is contained in:
Alexander Scheel
2023-01-18 10:40:35 -05:00
committed by GitHub
parent 04b2461c91
commit ebcd653102
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
command/pki_health_check_test.go
View File

@@ -16,8 +16,6 @@ import (
)
func TestPKIHC_AllGood(t *testing.T) {
t.Parallel()
client, closer := testVaultServer(t)
defer closer()
@@ -72,8 +70,6 @@ func TestPKIHC_AllGood(t *testing.T) {
}
func TestPKIHC_AllBad(t *testing.T) {
t.Parallel()
client, closer := testVaultServer(t)
defer closer()
@@ -134,8 +130,6 @@ func TestPKIHC_AllBad(t *testing.T) {
}
func TestPKIHC_OnlyIssuer(t *testing.T) {
t.Parallel()
client, closer := testVaultServer(t)
defer closer()
@@ -158,8 +152,6 @@ func TestPKIHC_OnlyIssuer(t *testing.T) {
}
func TestPKIHC_NoMount(t *testing.T) {
t.Parallel()
client, closer := testVaultServer(t)
defer closer()
@@ -174,8 +166,6 @@ func TestPKIHC_NoMount(t *testing.T) {
}
func TestPKIHC_ExpectedEmptyMount(t *testing.T) {
t.Parallel()
client, closer := testVaultServer(t)
defer closer()
@@ -196,8 +186,6 @@ func TestPKIHC_ExpectedEmptyMount(t *testing.T) {
}
func TestPKIHC_NoPerm(t *testing.T) {
t.Parallel()
client, closer := testVaultServer(t)
defer closer()